Resolve plugins path properly in migration commands #94
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JiriLojda
force-pushed
the
fix_imports_in_migrations
branch
from
b719391
to
5a1b951
Compare
pokornyd
reviewed
Oct 31, 2024
| return { err: `Provided plugins path ${path} does not exists` }; | ||
| export const loadStatusPlugin = async (pluginsPath: string): Promise<WithErr<StatusPlugin>> => { | ||
| if (!fs.existsSync(pluginsPath)) { | ||
| return { err: `Provided plugins path ${pluginsPath} does not exists` }; |
pokornyd
approved these changes
Oct 31, 2024
- plain absolute paths don't work on Windows so they need to be converted to file URLs
JiriLojda
force-pushed
the
fix_imports_in_migrations
branch
from
5a1b951
to
b4b6ee3
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
Which issue does this fix? Fixes #
issue numberIf no issue exists, what is the fix or new feature? Were there any reasons to fix/implement things that are not obvious?
Checklist
How to test
If manual testing is required, what are the steps?