feat: Add managementApiUrl option #45
Conversation
JiriLojda
requested review from
IvanKiral,
Enngage and
a team
as code owners
| @@ -102,6 +105,7 @@ const run = async () => { | |||
|
|
|||
| await generateModelsAsync({ | |||
| environmentId: environmentId, | |||
| managementApiUrl: resolvedArgs.managementApiUrl, | |||
There was a problem hiding this comment.
all the other parameters are in variables why not this one? :D
There was a problem hiding this comment.
Because I don't think there is any reasonable value in doing so. If anything it obscures the data flow a bit.
There was a problem hiding this comment.
Yeah, there is no real reason:) You could've unified it though because consistency is also important.
| @@ -38,6 +38,7 @@ export interface IGenerateModelsConfig { | |||
| isEnterpriseSubscription: boolean; | |||
| sdkType: SdkType; | |||
| apiKey: string; | |||
| managementApiUrl?: string; | |||
There was a problem hiding this comment.
add the information about the URL to the readme. maybe here?: https://github.com/JiriLojda/model-generator-js/tree/master#cli-configuration
There was a problem hiding this comment.
I intentionally left it, because I consider this an internal configuration key that most users outside Kontent.ai employees won't need. That being said there isn't much harm in adding it either.
Enngage
changed the title
Motivation
Sometimes it is useful (or even necessary) to specify a custom Kontent.ai Management API URL. (e.g. when using a proxy, or QA environment). This PR introduces a configuration option (in code only) that makes this possible.
Internal link: DEVREL-955