Limit amount searches to 20M€ #75
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hihuz
force-pushed
the
chore/limit-amount-max-value
branch
from
a097493 to
8b55afa
Compare
hihuz
force-pushed
the
chore/limit-amount-max-value
branch
from
8b55afa to
5e93ce3
Compare
p-janik
approved these changes
Mar 2, 2020
lera
approved these changes
Mar 2, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Following a comment from @p-janik in app search PR: https://github.com/kontist/figure-app/pull/4867#issuecomment-592493816
I looked a bit more and the
IntGraphQL scalar type only supports 32 bit integers (see: graphql/graphql-spec#73 (comment)). If we specify a number above that, our GraphQL API will throw.So I think it's a good idea to not include amount filter in search when user types a number above 20 millions (in euros).
This should be more than enough to cover all use cases.