Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(20564): center profile loading icon #959

Conversation

Natallia-Harshunova
Copy link
Contributor

@Natallia-Harshunova Natallia-Harshunova commented Jan 15, 2025

https://kontur.fibery.io/Tasks/Task/FE-Loading-icon-is-placed-on-top-left-corner-when-loading-profile-20564

Summary by CodeRabbit

  • New Features
    • Updated loading indicator in settings form to use a full-screen loader
  • Refactor
    • Simplified loading state visualization with a new component

@Natallia-Harshunova Natallia-Harshunova requested a review from a team January 15, 2025 08:20
Copy link
Contributor

coderabbitai bot commented Jan 15, 2025

Walkthrough

The pull request introduces a modification to the SettingsForm.tsx component, specifically updating the loading state rendering. The change involves replacing the existing spinner implementation with a new FullScreenLoader component, which simplifies the loading indication mechanism while maintaining the same conditional rendering logic.

Changes

File Change Summary
src/features/user_profile/.../SettingsForm.tsx - Added import for FullScreenLoader from ~components/LoadingSpinner/LoadingSpinner
- Replaced KonturSpinner with FullScreenLoader for initial loading state

Poem

🐰 A spinner's dance, now sleek and bright,
Full-screen loader takes its flight!
Code refactored with rabbit's grace,
Loading state finds its new embrace.
Simplicity hops, complexity fades. 🚀


Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

❤️ Share
🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>, please review it.
    • Generate unit testing code for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit testing code for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    • @coderabbitai read src/utils.ts and generate unit testing code.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai generate docstrings to generate docstrings for this PR. (Beta)
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

Copy link

Language To Recheck Fuzzy Untranslated Total
ar 3 24 101 128
de 2 24 101 127
es 3 24 101 128
id 2 24 101 127
ko 3 24 101 128
uk 0 7 8 15

Copy link

Bundle size diff

Old size New size Diff
5.16 MB 5.16 MB -47 B (-0.00%)

Copy link

codecov bot commented Jan 15, 2025

Codecov Report

Attention: Patch coverage is 0% with 1 line in your changes missing coverage. Please review.

Project coverage is 10.04%. Comparing base (57d4ad8) to head (2d9fc4c).
Report is 3 commits behind head on main.

Files with missing lines Patch % Lines
...r_profile/components/SettingsForm/SettingsForm.tsx 0.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #959      +/-   ##
==========================================
+ Coverage   10.02%   10.04%   +0.02%     
==========================================
  Files         669      668       -1     
  Lines       29463    29398      -65     
  Branches     1236     1235       -1     
==========================================
  Hits         2954     2954              
+ Misses      25979    25915      -64     
+ Partials      530      529       -1     
Components Coverage Δ
UI Components 0.26% <ø> (-0.01%) ⬇️
Core Logic 17.81% <ø> (-0.01%) ⬇️
Features 1.13% <0.00%> (+<0.01%) ⬆️
Utilities 45.77% <ø> (ø)

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 1

📜 Review details

Configuration used: CodeRabbit UI
Review profile: ASSERTIVE
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 18c0da8 and 2d9fc4c.

📒 Files selected for processing (1)
  • src/features/user_profile/components/SettingsForm/SettingsForm.tsx (2 hunks)
⏰ Context from checks skipped due to timeout of 90000ms (1)
  • GitHub Check: test
🔇 Additional comments (1)
src/features/user_profile/components/SettingsForm/SettingsForm.tsx (1)

21-21: LGTM!

Clean import addition, consistently placed with other component imports.

Copy link

Preview environments for this PR:

These previews are automatically updated with each commit.

Note: After a new deployment, it may take a few minutes for the changes to propagate and for caches to update. During this time, you might experience temporary loading issues or see an older version of the app. If the app fails to load, please wait a few minutes and try again.

Copy link

codecov bot commented Jan 15, 2025

Bundle Report

Changes will decrease total bundle size by 47 bytes (-0.0%) ⬇️. This is within the configured threshold ✅

Detailed changes
Bundle name Size Change
konturio/disaster-ninja-fe-esm 5.41MB 47 bytes (-0.0%) ⬇️

@Natallia-Harshunova Natallia-Harshunova merged commit 5a62fb4 into main Jan 15, 2025
17 of 22 checks passed
@Natallia-Harshunova Natallia-Harshunova deleted the 20564-fe-loading-icon-is-placed-on-top-left-corner-when-loading-profile branch January 15, 2025 10:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants