Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

var to const or let #1830

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

var to const or let #1830

wants to merge 2 commits into from
+720 −721

Conversation

tbo47
Copy link

@tbo47 tbo47 commented Oct 5, 2024 •
edited
Loading

I used eslint to change var to const or let. There is some var left, it's for when eslint didn't know.

I changed: ` pointerDirection: GetSet<'left' | 'top' | 'right' | 'bottom' | 'up' | 'down', this>;

To fix:

Error: src/shapes/Label.ts(231,9): error TS2367: This comparison appears to be unintentional because the types '"left" | "top" | "bottom" | "right"' and '"up"' have no overlap.
Error: src/shapes/Label.ts(263,9): error TS2367: This comparison appears to be unintentional because the types '"left" | "top" | "bottom" | "right"' and '"down"' have no overlap.
Error: src/shapes/Label.ts(300,9): error TS2367: This comparison appears to be unintentional because the types '"left" | "top" | "bottom" | "right"' and '"up"' have no overlap.
Error: src/shapes/Label.ts(303,16): error TS2367: This comparison appears to be unintentional because the types '"left" | "top" | "bottom" | "right"' and '"down"' have no overlap.
Error: Process completed with exit code 1.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@tbo47