Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Handle public-id field in xmlfile conditions #221

Closed
jmle opened this issue Jun 19, 2023 · 1 comment · Fixed by #306
Closed

Handle public-id field in xmlfile conditions #221

jmle opened this issue Jun 19, 2023 · 1 comment · Fixed by #306
Assignees
@aufi
Labels
parity
Milestone
v0.3.0

Comments

@jmle
Copy link
Contributor

jmle commented Jun 19, 2023

The public-id field in xmlfile conditions indicates the Formal Public Identifier of the DTD, and it's present in some windup rules which are currently failing.
@pranavgaikwad pranavgaikwad moved this to 🆕 New in Konveyor Analyzers Jul 3, 2023
@aufi
Copy link
Member

aufi commented Aug 16, 2023

I'm going to work on this.

@pranavgaikwad pranavgaikwad moved this from 🆕 New to 📋 TODO in Konveyor Analyzers Aug 17, 2023
aufi added a commit to aufi/windup-shim that referenced this issue Aug 23, 2023
@aufi
Handle public-id and system-id XML attributes
f25396f 
XML buildin rule supported only "matches" option, enabling system-id and
public-id.

Related to konveyor/analyzer-lsp#221

Signed-off-by: Marek Aufart <maufart@redhat.com>
@aufi aufi mentioned this issue Aug 23, 2023
Merged
aufi added a commit to aufi/analyzer-lsp that referenced this issue Aug 25, 2023
@aufi
Add XMLPublicid condition to buildtin provider
b835111 
Adding XML-like public-id condition supporting regular expression
evaluation on the public-id attribute.

Related to konveyor/windup-shim#87
Related to konveyor#221

Signed-off-by: Marek Aufart <maufart@redhat.com>
@aufi aufi mentioned this issue Aug 25, 2023
Merged
@dymurray dymurray moved this to 🔖 Ready in Planning Sep 15, 2023
@dymurray dymurray moved this from 🔖 Ready to 📋 Backlog in Planning Sep 15, 2023
@pranavgaikwad pranavgaikwad moved this from 📋 Backlog to 🏗 In progress in Planning Sep 27, 2023
@pranavgaikwad pranavgaikwad added this to the 0.3-beta.1 milestone Sep 27, 2023
@dymurray dymurray modified the milestones: 0.3-beta.1 , 0.3-beta.2 Oct 12, 2023
@djzager djzager modified the milestones: 0.3-beta.2, v0.3.0 Nov 9, 2023
@aufi aufi closed this as completed in #306 Dec 12, 2023
aufi added a commit that referenced this issue Dec 12, 2023
@aufi
✨ Add XMLPublicID condition to builtin provider (#306)
ca8ced3 
Adding XML-like public-id condition supporting regular expression
evaluation on the public-id attribute.

Related to konveyor/windup-shim#87

Fixes: #221

Analyzer PR: 306
Windup-shim PR: 87

---------

Signed-off-by: Marek Aufart <maufart@redhat.com>
Signed-off-by: Marek Aufart <aufi.cz@gmail.com>
@github-project-automation github-project-automation bot moved this from 🏗 In progress to ✅ Done in Planning Dec 12, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@aufi aufi

Labels
parity
Projects
Planning
Status: ✅ Done
Konveyor Analyzers
Status: 📋 TODO
Milestone
v0.3.0
Development

Successfully merging a pull request may close this issue.

✨ Add XMLPublicID condition to builtin provider aufi/analyzer-lsp
5 participants
@aufi @djzager @jmle @pranavgaikwad @dymurray