[BUG] "konveyor-analyzer-dep --help" keeps running instead of showing help and stopping

[jmle]

Is there an existing issue for this?

• I have searched the existing issues

Konveyor version

0.3.0-beta2

Priority

Minor

Current Behavior

When running konveyor-analyzer-dep --help, the command shows the help and keeps running instead of exiting.

Expected Behavior

The command should show the help and exit.

How Reproducible

Always (Default)

Steps To Reproduce

1. Run [docker|podman] run -ti --entrypoint /bin/bash <latest analyzer-lsp image>
2. Run konveyor-analyzer-help within the container.

Environment

- Fedora 38
- Latest analyzer-lsp image

Anything else?

No response

[Vickysomtee]

@shawn-hurley can this be assigned to me? I want to work on it

[shawn-hurley]

@Vickysomtee all yours!

[Vickysomtee]

@jmle the command you provided in the second step to reproduce returns

bash: konveyor-analyzer-help: command not found

I decided to try konveyor-analyzer-dep --help This is the output below and it exited

[jmle]

Hey @Vickysomtee, thank you for taking a look. The log messages that appear after the "Flags" section indicate that the bin is actually running a dependency analysis, and that shouldn't happen. That is what should be fixed.

[shawn-hurley]

@Vickysomtee, that is correct on the command konveyor-analyzer-dep --help, you are on the right track.

I think that you want to look at a line like this: if err := rootCmd.Execute(); err != nil {

I think that if there is an error, we need to stop executing.

We also need to handle the case when help is specifcally called like:} else if rootCmd.Flags().Changed("help") {

Let me know if that helps?

[Vickysomtee]

@shawn-hurley Thanks for the pointers, I have a better understanding.

One quick question about this.

We also need to handle the case when help is specifcally called like:} else if rootCmd.Flags().Changed("help") {

What should happen when help is specifically called

[shawn-hurley]

Print the help text, and then exit would be what would be best

[Vickysomtee]

Print the help text, and then exit would be what would be best

@shawn-hurley I am not sure I understood what you meant by Print the help text but I created a draft PR so you can review