Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Bug] Dependency file URIs of JARs are causing them to not match dep label selector #544

Closed
pranavgaikwad opened this issue Mar 19, 2024 · 1 comment · Fixed by #543
Closed

[Bug] Dependency file URIs of JARs are causing them to not match dep label selector #544

pranavgaikwad opened this issue Mar 19, 2024 · 1 comment · Fixed by #543
Assignees
@pranavgaikwad
Labels
kind/bug Categorizes issue or PR as related to a bug. priority/important-soon Must be staffed and worked on either currently, or very soon, ideally in time for the next release. triage/accepted Indicates an issue or PR is ready to be actively worked on.
Milestone
v0.3.1

Comments

@pranavgaikwad
Copy link
Contributor

We are not adding "file://" prefix to the filepaths of dependencies that we find in JARs. We need to correctly handle those paths for dep label selector to match. Also, we are moving original JARs to m2 repo we should be copying them so provider can still find them in their original place. Fixing this will fix dep-label-selector option correctly for JARs.
@pranavgaikwad pranavgaikwad self-assigned this Mar 19, 2024
@pranavgaikwad pranavgaikwad added this to the v0.3.1 milestone Mar 19, 2024
@konveyor-ci-bot
Copy link

This issue is currently awaiting triage.
If contributors determine this is a relevant issue, they will accept it by applying the triage/accepted label and provide further guidance.
The triage/accepted label can be added by org members.

@konveyor-ci-bot konveyor-ci-bot bot added needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. needs-kind Indicates an issue or PR lacks a `kind/foo` label and requires one. needs-priority Indicates an issue or PR lacks a `priority/foo` label and requires one. labels Mar 19, 2024
@pranavgaikwad pranavgaikwad added priority/important-soon Must be staffed and worked on either currently, or very soon, ideally in time for the next release. triage/accepted Indicates an issue or PR is ready to be actively worked on. and removed needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. needs-kind Indicates an issue or PR lacks a `kind/foo` label and requires one. needs-priority Indicates an issue or PR lacks a `priority/foo` label and requires one. labels Mar 19, 2024
@konveyor-ci-bot konveyor-ci-bot bot added the needs-kind Indicates an issue or PR lacks a `kind/foo` label and requires one. label Mar 19, 2024
@pranavgaikwad pranavgaikwad added the kind/bug Categorizes issue or PR as related to a bug. label Mar 19, 2024
@pranavgaikwad pranavgaikwad mentioned this issue Mar 19, 2024
Merged
@konveyor-ci-bot konveyor-ci-bot bot removed the needs-kind Indicates an issue or PR lacks a `kind/foo` label and requires one. label Mar 19, 2024
pranavgaikwad added a commit that referenced this issue Mar 19, 2024
@pranavgaikwad
🐛 Fix file URI prefix for JARs and do not move found JARs so dependen…
650120f 
…cy CLI can still find them (#543)

Fixes #544

Signed-off-by: Pranav Gaikwad <pgaikwad@redhat.com>
aufi pushed a commit to aufi/analyzer-lsp that referenced this issue Mar 25, 2024
@pranavgaikwad @aufi
🐛 Fix file URI prefix for JARs and do not move found JARs so dependen…
ccd6405 
…cy CLI can still find them (konveyor#543)

Fixes konveyor#544

Signed-off-by: Pranav Gaikwad <pgaikwad@redhat.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@pranavgaikwad pranavgaikwad

Labels
kind/bug Categorizes issue or PR as related to a bug. priority/important-soon Must be staffed and worked on either currently, or very soon, ideally in time for the next release. triage/accepted Indicates an issue or PR is ready to be actively worked on.
Projects
Planning
Status: ✅ Done
Milestone
v0.3.1
1 participant
@pranavgaikwad