Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🐛 Fix empty code snippet in XML when the match is a key of the node, not an inner value #504

Merged
merged 3 commits into from
Feb 20, 2024

Conversation

pranavgaikwad
Copy link
Contributor

Fixes #503

Signed-off-by: Pranav Gaikwad <pgaikwad@redhat.com>
@djzager djzager added the cherry-pick/release-0.3 This PR should be cherry-picked to release-0.3 branch. label Feb 20, 2024
Co-authored-by: David Zager <dzager@redhat.com>
Signed-off-by: Pranav Gaikwad <pgaikwad@redhat.com>
Copy link
Member

@djzager djzager left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

Copy link
Contributor

@shawn-hurley shawn-hurley left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you add a e2e test for this case?

Signed-off-by: Pranav Gaikwad <pgaikwad@redhat.com>
@pranavgaikwad
Copy link
Contributor Author

@shawn-hurley added

@shawn-hurley shawn-hurley merged commit 4bee4ab into konveyor:main Feb 20, 2024
6 checks passed
pranavgaikwad added a commit to pranavgaikwad/analyzer-lsp that referenced this pull request Feb 21, 2024
…not an inner value (konveyor#504)

Fixes konveyor#503

---------

Signed-off-by: Pranav Gaikwad <pgaikwad@redhat.com>
Co-authored-by: David Zager <dzager@redhat.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cherry-pick/release-0.3 This PR should be cherry-picked to release-0.3 branch.
Projects
None yet
4 participants