✨ Adding ability to output spec data #516
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -242,3 +265,121 @@ func validateFlags() error { | |||
|
|
|||
| return nil | |||
| } | |||
|
|
|||
| func createOpenAPISchema(providers map[string]provider.InternalProviderClient, log logr.Logger) openapi3.Spec { | |||
shawn-hurley
force-pushed
the
feature/add-openapi-output
branch
from
ef228b9 to
cf80511
Compare
shawn-hurley
changed the title
Signed-off-by: Shawn Hurley <shawn@hurley.page>
Signed-off-by: Shawn Hurley <shawn@hurley.page>
Signed-off-by: Shawn Hurley <shawn@hurley.page>
Signed-off-by: Shawn Hurley <shawn@hurley.page>
Signed-off-by: Shawn Hurley <shawn@hurley.page>
shawn-hurley
force-pushed
the
feature/add-openapi-output
branch
from
cf80511 to
e43e012
Compare
Signed-off-by: Shawn Hurley <shawn@hurley.page>
shawn-hurley
force-pushed
the
feature/add-openapi-output
branch
from
6dcfc9e to
ea7ad8c
Compare
|
Given the nature of the swagger UI, we would need to define a rest API like a contract. For our purpose, this is probably not what we want right now, skipping the display. |
shawn-hurley
commented
Mar 6, 2024
...rnal-providers/generic-external-provider/pkg/server_configurations/generic/service_client.go
Outdated
Show resolved
Hide resolved
...providers/generic-external-provider/pkg/server_configurations/generic/service_client_test.go
Outdated
Show resolved
Hide resolved
...l-providers/generic-external-provider/pkg/server_configurations/pylsp/service_client_test.go
Outdated
Show resolved
Hide resolved
| @@ -134,9 +134,7 @@ func (p *javaServiceClient) GetDependenciesFallback(ctx context.Context, locatio | |||
| p.log.V(10).Info("Analyzing POM", | |||
| "POM", fmt.Sprintf("%s:%s:%s", pomCoordinate(pom.GroupID), pomCoordinate(pom.ArtifactID), pomCoordinate(pom.Version)), | |||
| "error", err) | |||
| if err != nil { | |||
There was a problem hiding this comment.
Note to reviewer: this is because this err is checked above this is a redundant call
| @@ -672,7 +686,7 @@ func getVersion(depVersion string) (*version.Version, error) { | |||
| return v, nil | |||
| } | |||
| // Parsing failed so we'll try to extract a version and parse that | |||
| re := regexp.MustCompile("v?([0-9]+(?:\\.[0-9]+)*)") | |||
| re := regexp.MustCompile(`v?([0-9]+(?:.[0-9]+)*)`) | |||
There was a problem hiding this comment.
note to reviewer, this is something that vs code told me was a warning
Signed-off-by: Shawn Hurley <shawn@hurley.page>
shawn-hurley
force-pushed
the
feature/add-openapi-output
branch
from
e2c255b to
802ce3f
Compare
pranavgaikwad
approved these changes
Mar 6, 2024
This was referenced May 8, 2024
This was referenced Jun 5, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adding the ability for the spec of the given components to be rendered in swagger open API.
TODO: