🐛 improve decompile performance #530
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Pranav Gaikwad <pgaikwad@redhat.com>
Signed-off-by: Pranav Gaikwad <pgaikwad@redhat.com>
shawn-hurley
approved these changes
Mar 11, 2024
aufi
pushed a commit
to aufi/analyzer-lsp
that referenced
this pull request
Mar 25, 2024
This improves decompilation performance significantly. Also adds more
tracing spans so we get more visibility into decomp perf in future.
Before:
* Full analysis via kantra in source + deps mode
_InProgress_
* Decompile performance (41 sec per file, 22451 sec total)
After:
* Full analysis via kantra in source + deps mode (improved by )
```
real 10m21.651s
user 0m1.978s
sys 0m2.554s
```
* Decompile performance (3.1 sec on per file, 1683 sec total, improved
by ~93%)
There's one more issue we need to fix. We are decompiling for dependency
CLI too. That's because we use the same _Init()_ function for analyzer
and dep cli. We either need to combine these two commands, or have an
alternate _InitDep()_ function interface on providers that does a light
weight init of providers. Captured in
konveyor#529
---------
Signed-off-by: Pranav Gaikwad <pgaikwad@redhat.com>
This was referenced May 8, 2024
This was referenced Jun 5, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This improves decompilation performance significantly. Also adds more tracing spans so we get more visibility into decomp perf in future.
Before:
Full analysis via kantra in source + deps mode
InProgress
Decompile performance (41 sec per file, 22451 sec total)
After:
Full analysis via kantra in source + deps mode (improved by )
Decompile performance (3.1 sec on per file, 1683 sec total, improved by ~93%)
There's one more issue we need to fix. We are decompiling for dependency CLI too. That's because we use the same Init() function for analyzer and dep cli. We either need to combine these two commands, or have an alternate InitDep() function interface on providers that does a light weight init of providers. Captured in #529