✨ Adding output/template context to open api spec. #549
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
shawn-hurley
changed the title
shawn-hurley
commented
Mar 22, 2024
| @@ -147,7 +151,7 @@ func (p *builtinServiceClient) Evaluate(ctx context.Context, cap string, conditi | |||
| if query == nil || err != nil { | |||
| return response, fmt.Errorf("could not parse provided xpath query '%s': %v", cond.XML.XPath, err) | |||
| } | |||
| xmlFiles, err := findXMLFiles(p.config.Location, cond.XMLPublicID.Filepaths) | |||
| xmlFiles, err := findXMLFiles(p.config.Location, cond.XML.Filepaths) | |||
There was a problem hiding this comment.
This is a bug that I found while testing
shawn-hurley
commented
Mar 22, 2024
| @@ -29,7 +29,7 @@ | |||
| or: | |||
| - builtin.xml: | |||
| xpath: "//dependencies/dependency" | |||
| filepaths: "{{poms.filepaths}}" | |||
| filepaths: "{{poms.extras.filepaths}}" | |||
There was a problem hiding this comment.
Updating to extras to make sure that the TemplateContext works, we should maybe have another test that tests the file paths from incidents are working.
pranavgaikwad
approved these changes
Apr 3, 2024
* added new helper to add this to capability * used new helper in builtin where we had template context * updated docs to make it more clear. Signed-off-by: Shawn Hurley <shawn@hurley.page>
shawn-hurley
force-pushed
the
feature/add-output-provider-caps
branch
from
9f3bc0c
to
03e92bf
Compare
This was referenced May 8, 2024
This was referenced Jun 5, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #527