Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🐛 Adding parsing of non WEB-INF classes as dependencies #553

Merged
merged 1 commit into from
Mar 26, 2024

Conversation

shawn-hurley
Copy link
Contributor

fixes #533

Copy link
Member

@djzager djzager left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ack w/ nitpicks that I think deserve to be addressed before approval.

provider/internal/java/dependency.go Outdated Show resolved Hide resolved
provider/internal/java/util.go Outdated Show resolved Hide resolved
@shawn-hurley shawn-hurley force-pushed the bugfix/issue-533 branch 2 times, most recently from db4d65a to 337c72f Compare March 26, 2024 15:11
Copy link
Contributor

@pranavgaikwad pranavgaikwad left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Small nit, looking good otherwise. Thank you!

provider/internal/java/dependency.go Outdated Show resolved Hide resolved
@shawn-hurley shawn-hurley force-pushed the bugfix/issue-533 branch 2 times, most recently from 337c72f to 269810e Compare March 26, 2024 16:39
Signed-off-by: Shawn Hurley <shawn@hurley.page>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[BUG] War file class files are not correctly identified in Dependencies
3 participants