✨ Add dockerfiles for providers and run the demo using the external providers in a Pod #579
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pranavgaikwad
force-pushed
the
splitDockerfiles
branch
from
6e10dd6
to
225eee2
Compare
pranavgaikwad
force-pushed
the
splitDockerfiles
branch
3 times, most recently
from
39b5572
to
f9aa190
Compare
Signed-off-by: Pranav Gaikwad <pgaikwad@redhat.com>
pranavgaikwad
force-pushed
the
splitDockerfiles
branch
2 times, most recently
from
019231b
to
ef51d11
Compare
djzager
requested changes
Apr 17, 2024
Co-authored-by: David Zager <dzager@redhat.com> Signed-off-by: Pranav Gaikwad <pgaikwad@redhat.com>
Co-authored-by: David Zager <dzager@redhat.com> Signed-off-by: Pranav Gaikwad <pgaikwad@redhat.com>
|
Nothing looks wrong to me, this is really good! thank you! |
This was referenced May 8, 2024
This was referenced Jun 5, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #470
I have still kept the original base Dockerfile as-is for backwards compatibility. This is the first step in which we are chaging our demo tests to use the external providers. I will create a follow up issue to track the work around actually making the switch in the addon.