✨ Make providers return a builtin config so engine can look at updated locations #671
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Pranav Gaikwad <pgaikwad@redhat.com>
Signed-off-by: Pranav Gaikwad <pgaikwad@redhat.com>
Signed-off-by: Pranav Gaikwad <pgaikwad@redhat.com>
shawn-hurley
force-pushed
the
feature/builtin-configs
branch
from
a9ef16b
to
bb280f4
Compare
shawn-hurley
force-pushed
the
feature/builtin-configs
branch
from
b4555b8
to
2c6f6fb
Compare
Signed-off-by: Pranav Gaikwad <pgaikwad@redhat.com> fixup
shawn-hurley
force-pushed
the
feature/builtin-configs
branch
from
921273f
to
405b48c
Compare
shawn-hurley
added
the
cherry-pick/release-0.5
pranavgaikwad
requested changes
Jul 29, 2024
* switching to the bundle CI Signed-off-by: Shawn Hurley <shawn@hurley.page>
shawn-hurley
force-pushed
the
feature/builtin-configs
branch
from
9cd7ebb
to
5087451
Compare
shawn-hurley
changed the title
|
LGTM, Just a note run API tests with not-merged PR from go-konveyor-tests could be done adding "API tests PR: XYZ" to PR description (details https://github.com/konveyor/ci/blob/main/.github/workflows/global-ci.yml#L150) |
|
@aufi Yeah that is true, problem is that this only works when you first open the PR |
pranavgaikwad
approved these changes
Jul 29, 2024
github-actions bot
pushed a commit
that referenced
this pull request
Jul 29, 2024
…d locations (#671) Some providers can mutate the original location given in init config. For example, for binaries, java provider decompiles and uses the new decompiled path. This PR adds a way for providers to communicate updated locations back to the engine so builtin provider can be configured correctly without the user having to do it. --------- Signed-off-by: Pranav Gaikwad <pgaikwad@redhat.com> Signed-off-by: Shawn Hurley <shawn@hurley.page> Co-authored-by: Pranav Gaikwad <pgaikwad@redhat.com> Signed-off-by: Cherry Picker <noreply@github.com>
shawn-hurley
added a commit
that referenced
this pull request
Jul 29, 2024
…d locations (#671) (#677) Some providers can mutate the original location given in init config. For example, for binaries, java provider decompiles and uses the new decompiled path. This PR adds a way for providers to communicate updated locations back to the engine so builtin provider can be configured correctly without the user having to do it. --------- Signed-off-by: Pranav Gaikwad <pgaikwad@redhat.com> Signed-off-by: Shawn Hurley <shawn@hurley.page> Co-authored-by: Pranav Gaikwad <pgaikwad@redhat.com> Signed-off-by: Cherry Picker <noreply@github.com> Signed-off-by: Pranav Gaikwad <pgaikwad@redhat.com> Signed-off-by: Shawn Hurley <shawn@hurley.page> Signed-off-by: Cherry Picker <noreply@github.com> Co-authored-by: Shawn Hurley <shawn@hurley.page> Co-authored-by: Pranav Gaikwad <pgaikwad@redhat.com>
jortel
added a commit
to konveyor/tackle2-addon-analyzer
that referenced
this pull request
Aug 1, 2024
closes #93 Requires: - konveyor/tackle2-hub#668 - konveyor/analyzer-lsp#671 - konveyor/analyzer-lsp#686 --------- Signed-off-by: Jeff Ortel <jortel@redhat.com>
github-actions bot
pushed a commit
to konveyor/tackle2-addon-analyzer
that referenced
this pull request
Aug 1, 2024
closes #93 Requires: - konveyor/tackle2-hub#668 - konveyor/analyzer-lsp#671 - konveyor/analyzer-lsp#686 --------- Signed-off-by: Jeff Ortel <jortel@redhat.com> Signed-off-by: Cherry Picker <noreply@github.com>
jortel
added a commit
to konveyor/tackle2-addon-analyzer
that referenced
this pull request
Aug 1, 2024
closes #93 Requires: - konveyor/tackle2-hub#668 - konveyor/analyzer-lsp#671 - konveyor/analyzer-lsp#686 --------- Signed-off-by: Jeff Ortel <jortel@redhat.com> Signed-off-by: Cherry Picker <noreply@github.com> Signed-off-by: Jeff Ortel <jortel@redhat.com> Signed-off-by: Cherry Picker <noreply@github.com> Co-authored-by: Jeff Ortel <jortel@redhat.com>
This was referenced Oct 1, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Some providers can mutate the original location given in init config. For example, for binaries, java provider decompiles and uses the new decompiled path. This PR adds a way for providers to communicate updated locations back to the engine so builtin provider can be configured correctly without the user having to do it.