✨ try to get import references when found #688
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
shawn-hurley
force-pushed
the
feature/try-new-things
branch
from
e8f0341
to
6a84a7f
Compare
shawn-hurley
changed the title
Signed-off-by: Shawn Hurley <shawn@hurley.page>
shawn-hurley
force-pushed
the
feature/try-new-things
branch
from
6a84a7f
to
37178e0
Compare
djzager
added
the
cherry-pick/release-0.5
djzager
approved these changes
Aug 8, 2024
github-actions bot
pushed a commit
that referenced
this pull request
Aug 8, 2024
@djzager Basically, when we do our fall back we can find the imports mostly correct, but imports are for namespaces not for actual objects so no definition can be used. Therefore we are getting zero results back for the definiton. We can get all the references for the import though, and we can just let the analyzer dedup. If you could help get me a windows container image to test with that would helpful (or show me how) Signed-off-by: Shawn Hurley <shawn@hurley.page> Signed-off-by: Cherry Picker <noreply@github.com>
This was referenced Oct 1, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@djzager
Basically, when we do our fall back we can find the imports mostly correct, but imports are for namespaces not for actual objects so no definition can be used. Therefore we are getting zero results back for the definiton.
We can get all the references for the import though, and we can just let the analyzer dedup.
If you could help get me a windows container image to test with that would helpful (or show me how)