Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

🐛 make sure non java files are exploded to java project #760

Merged
merged 3 commits into from
Jan 15, 2025
Merged

🐛 make sure non java files are exploded to java project #760

merged 3 commits into from
Jan 15, 2025

Conversation

pranavgaikwad
Copy link
Contributor

@pranavgaikwad pranavgaikwad commented Jan 14, 2025 •
edited
Loading

API Tests PR: 249

@pranavgaikwad
🐛 make sure non java files are exploded to java project
3ba4ad3 
Signed-off-by: Pranav Gaikwad <pgaikwad@redhat.com>
@dymurray dymurray added the cherry-pick/release-0.6 This PR should be cherry-picked to release-0.6 branch label Jan 14, 2025
@pranavgaikwad
👻 update demo output
f1169df 
Signed-off-by: Pranav Gaikwad <pgaikwad@redhat.com>
@dymurray dymurray mentioned this pull request Jan 15, 2025
Merged
aufi
aufi approved these changes Jan 15, 2025
View reviewed changes
Copy link
Member

@aufi aufi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@aufi
Copy link
Member

aufi commented Jan 15, 2025 •
edited
Loading

Regarding to test failures, failed acmeair-webapp and tackle-testapp-binary added an issue in .properties file which looks good and API tests should be updated (as well as Tags) in follow-up PR to go-konveyor-tests.

However, administracion-efectivo cannot find any issue now (local-storage-00001 and local-storage-00002 from .java files were expected), which looks strange and probabaly needs some care on analyzer side (test case: https://github.com/konveyor/go-konveyor-tests/blob/main/analysis/tc_administracion_efectivo_upload_binary.go)

@pranavgaikwad
🐛 make sure file paths don't contain bad characters:
b6b0f12 
Signed-off-by: Pranav Gaikwad <pgaikwad@redhat.com>
@pranavgaikwad pranavgaikwad merged commit 2f9344a into konveyor:main Jan 15, 2025
11 checks passed
github-actions bot pushed a commit that referenced this pull request Jan 15, 2025
@pranavgaikwad @web-flow
🐛 make sure non java files are exploded to java project (#760)
10dc05f 
API Tests PR: 249

---------

Signed-off-by: Pranav Gaikwad <pgaikwad@redhat.com>
Signed-off-by: Cherry Picker <noreply@github.com>
dymurray pushed a commit that referenced this pull request Jan 15, 2025
@pranavgaikwad @dymurray
🐛 make sure non java files are exploded to java project (#760)
6984e9e 
---------

Signed-off-by: Pranav Gaikwad <pgaikwad@redhat.com>
Signed-off-by: Cherry Picker <noreply@github.com>
dymurray added a commit that referenced this pull request Jan 15, 2025
@dymurray @pranavgaikwad
🐛 make sure non java files are exploded to java project (#760) (#762)
db383c4 
Signed-off-by: Pranav Gaikwad <pgaikwad@redhat.com>
Signed-off-by: Cherry Picker <noreply@github.com>
Co-authored-by: Pranav Gaikwad <pgaikwad@redhat.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@aufi aufi aufi approved these changes

@eemcmullan eemcmullan eemcmullan approved these changes

Assignees
No one assigned
Labels
cherry-pick/release-0.6 This PR should be cherry-picked to release-0.6 branch
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@pranavgaikwad @aufi @eemcmullan @dymurray