Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use PR specific branches for E2E API tests from Hub #22

Closed
aufi opened this issue Nov 9, 2023 · 1 comment
Closed

Use PR specific branches for E2E API tests from Hub #22

aufi opened this issue Nov 9, 2023 · 1 comment
Assignees

Comments

@aufi
Copy link
Member

aufi commented Nov 9, 2023

Part of E2E API tests are Hub API tests that are executed from go-konveyor-tests repo using script [0]. Some changes in Hub API need execute E2E API tests using their version of Hub API tests (instead of main or release-* branches) to not cause "false" CI API failures.

It is needed possibility to sync Hub PR test changes with E2E API CI execution (on Hub PRs only).

[0] https://github.com/konveyor/go-konveyor-tests/blob/main/hub-api/run-tests.sh Note, BRANCH env variable is currently used for release-0.3 branches testing and likely should be reused for PRs.

@aufi aufi self-assigned this Nov 9, 2023
@aufi aufi added this to Planning Nov 9, 2023
@aufi aufi moved this to 🔖 Ready in Planning Nov 9, 2023
@aufi aufi moved this from 🔖 Ready to 🏗 In progress in Planning Nov 10, 2023
aufi added a commit to aufi/ci that referenced this issue Nov 10, 2023
Adding api_hub_tests_ref Github workflow input, that sets HUB_TESTS_REF
environment variable in go-konveyor-tests exection.

This varibale is used to run Hub API tests directly from branch of the Hub PR.

Related to konveyor#22

Signed-off-by: Marek Aufart <maufart@redhat.com>
aufi added a commit to aufi/go-konveyor-tests that referenced this issue Nov 15, 2023
Adding HUB_TESTS_REF variable to make test-api target to (optionally) set
Hub API tests branch.

Related to konveyor/ci#22 and konveyor/ci#23

Signed-off-by: Marek Aufart <maufart@redhat.com>
aufi added a commit to aufi/tackle2-hub that referenced this issue Nov 15, 2023
In order to run E2E API tests with tackle2-hub API tests on matching
branches, adding name of PR branch as a variable passed to CI workflow.

Depends on konveyor/ci#23

Related to konveyor/ci#22 and konveyor/go-konveyor-tests#61

Signed-off-by: Marek Aufart <maufart@redhat.com>
aufi added a commit to konveyor/go-konveyor-tests that referenced this issue Nov 29, 2023
* Make API tests using HUB_TESTS_REF variable

Adding HUB_TESTS_REF variable to make test-api target to (optionally) set
Hub API tests branch.

Related to konveyor/ci#22 and konveyor/ci#23

Signed-off-by: Marek Aufart <maufart@redhat.com>

* Replace ununsed BRANCH var

Signed-off-by: Marek Aufart <maufart@redhat.com>

---------

Signed-off-by: Marek Aufart <maufart@redhat.com>
aufi added a commit to konveyor/tackle2-hub that referenced this issue Nov 29, 2023
In order to run E2E API tests with tackle2-hub API tests on matching
branches, adding name of PR branch as a variable passed to CI workflow.

Depends on konveyor/ci#23

Related to konveyor/ci#22 and
konveyor/go-konveyor-tests#61

---------

Signed-off-by: Marek Aufart <maufart@redhat.com>
@aufi
Copy link
Member Author

aufi commented Nov 30, 2023

One more PR was needed konveyor/tackle2-hub#569

Looks to work well now, closing.

@aufi aufi closed this as completed Nov 30, 2023
@github-project-automation github-project-automation bot moved this from 🏗 In progress to ✅ Done in Planning Nov 30, 2023
aufi added a commit to konveyor/go-konveyor-tests that referenced this issue Dec 13, 2023
* Make API tests using HUB_TESTS_REF variable

Adding HUB_TESTS_REF variable to make test-api target to (optionally) set
Hub API tests branch.

Related to konveyor/ci#22 and konveyor/ci#23

Signed-off-by: Marek Aufart <maufart@redhat.com>

* Replace ununsed BRANCH var

Signed-off-by: Marek Aufart <maufart@redhat.com>

---------

Signed-off-by: Marek Aufart <maufart@redhat.com>
mguetta1 pushed a commit to mguetta1/go-konveyor-tests that referenced this issue Jan 31, 2024
* Make API tests using HUB_TESTS_REF variable

Adding HUB_TESTS_REF variable to make test-api target to (optionally) set
Hub API tests branch.

Related to konveyor/ci#22 and konveyor/ci#23

Signed-off-by: Marek Aufart <maufart@redhat.com>

* Replace ununsed BRANCH var

Signed-off-by: Marek Aufart <maufart@redhat.com>

---------

Signed-off-by: Marek Aufart <maufart@redhat.com>
Signed-off-by: Maayan Hadasi <mguetta@redhat.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: ✅ Done
Development

No branches or pull requests

1 participant