Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

✨ dotnet provider treesitter #204

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

djzager
Copy link
Member

@djzager djzager commented Aug 24, 2024

No description provided.

Signed-off-by: David Zager <dzager@redhat.com>
@djzager djzager added this to the v0.6.0 milestone Aug 24, 2024
@jortel
Copy link
Contributor

jortel commented Aug 27, 2024

This seems very promising.

Copy link
Member

@aufi aufi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me 👍

(I don't have good .net analyzer background, so giving just +1)

@djzager
Copy link
Member Author

djzager commented Sep 9, 2024

Sticking this in here for my future reference https://chatgpt.com/share/3fd9d6b9-eb81-4fd6-9fa2-427b5f527924

Copy link
Contributor

@shawn-hurley shawn-hurley left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would like to understand how we plan on also finding issues in dependencies.

If we currently can't do that, and this is not worse then that is ok, but we should at least think about this.

Is TreeSitter able to generate an AST from a .dll library?

@djzager
Copy link
Member Author

djzager commented Sep 12, 2024

If we currently can't do that, and this is not worse then that is ok, but we should at least think about this.

We can't do this currently...or at least we don't do this currently.

Is TreeSitter able to generate an AST from a .dll library?

I don't believe so, it looks like we can generate an AST for each file individually. So a dll would need to be unpacked first.

@shawn-hurley
Copy link
Contributor

That makes sense, I was just wondering. If this is not worse than before then I don't see a downside. I do want to have a plan, If we do make sure that we can unpack .DLL's and get the AST from them, then I will be completely satisfied that we can achieve what we need to in the future.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: 🆕 New
Development

Successfully merging this pull request may close these issues.

4 participants