Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

TIER3 Execution #70

Merged
merged 1 commit into from
Dec 6, 2023
Merged

TIER3 Execution #70

merged 1 commit into from
Dec 6, 2023

Conversation

mguetta1
Copy link
Collaborator

@mguetta1 mguetta1 commented Dec 3, 2023

No description provided.

@mguetta1 mguetta1 requested a review from sshveta December 3, 2023 13:42
aufi
aufi approved these changes Dec 5, 2023
View reviewed changes
Copy link
Member

@aufi aufi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'd suggest avoid wording "sensitive data" in tests, rather something like not public or tests that need credentials to access some repository or external service. Otherwise LGTM.

sshveta
sshveta reviewed Dec 5, 2023
View reviewed changes
README.md Outdated Show resolved Hide resolved
@mguetta1 mguetta1 force-pushed the tier3 branch 3 times, most recently from cead9f0 to e59e5ff Compare December 6, 2023 08:57
@mguetta1
Updating README.md with TIER3
ecc9a21 
Signed-off-by: Maayan Hadasi <mguetta@redhat.com>
@mguetta1 mguetta1 requested a review from sshveta December 6, 2023 09:03
@sshveta sshveta merged commit c36aa4a into konveyor:main Dec 6, 2023
3 of 4 checks passed
aufi pushed a commit that referenced this pull request Dec 13, 2023
@mguetta1 @aufi
Updating README.md with TIER3 (#70)
26728f3 
Signed-off-by: Maayan Hadasi <mguetta@redhat.com>
mguetta1 added a commit to mguetta1/go-konveyor-tests that referenced this pull request Jan 31, 2024
@mguetta1
Updating README.md with TIER3 (konveyor#70)
b460e31 
Signed-off-by: Maayan Hadasi <mguetta@redhat.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sshveta sshveta sshveta approved these changes

@aufi aufi aufi approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@mguetta1 @aufi @sshveta