🐛 check accuracy of TypeReferenceMatch & MethodReferenceMatch #91
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Pranav Gaikwad <pgaikwad@redhat.com> :update: Signed-off-by: Pranav Gaikwad <pgaikwad@redhat.com>
Signed-off-by: Pranav Gaikwad <pgaikwad@redhat.com>
pranavgaikwad
changed the title
| var element = (IJavaElement) match.getElement(); | ||
| ICompilationUnit compilationUnit = (ICompilationUnit) element | ||
| .getAncestor(IJavaElement.COMPILATION_UNIT); | ||
| if (compilationUnit == null) { |
There was a problem hiding this comment.
Just for my own understanding when does this happen?
There was a problem hiding this comment.
If I understood it correctly, this happens when match is in a .class file. In that case, the compilation unit needs to be loaded into memory. Fortunately, the class file doesn't need to be decompiled....we can somehow get imports, package declaration, methods etc just from the class file handle
shawn-hurley
approved these changes
Mar 28, 2024
Signed-off-by: Pranav Gaikwad <pgaikwad@redhat.com>
|
I will do a similar thing for annotations too when I get the time, this addresses most of the test failures. I will get back to it after I am done with testing stuff. tracking it here #92 |
This was referenced May 8, 2024
This was referenced Jun 5, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This removes accuracy checks that depend on errors in the project.
I observed that most inaccurate matches we get are from TypeReferenceMatch matches, this is because they do not take into account fully qualified names of types.
There is also some instances of inaccurate stuff coming from method calls, this fixes the search pattern to be fully qualified instead of all references.