Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

✨ Added preliminary cli script #471

Open
wants to merge 1 commit into
base: feature/rebase-repo-level-awareness
Choose a base branch
from

Conversation

JonahSussman
Copy link
Contributor

No description provided.

Signed-off-by: JonahSussman <sussmanjonah@gmail.com>
Copy link
Contributor

@shawn-hurley shawn-hurley left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I am wondering, if we want to take a second and design it, so that a user can make the calls that would be in the file, but via the CLI interface. something like:

a command that takes a file as input, and an optional violation information. then returns with the result of solving that file.

I am worried that this approach someone would have to understand the JSONRPC and that doesn't seem like the right interface for a user.

request=request, server=server, app=self
)
if not any_executed:
log.error(f"Notify method not found: {request.method}")
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Shouldn't this be an error?

@JonahSussman
Copy link
Contributor Author

@shawn-hurley Ah I see. So this is less having something for testing stuff and more having an IDE that an actual end user could use, if I'm understanding correctly?

@shawn-hurley
Copy link
Contributor

I don't know about an IDE more like a CLI tool to just "do it" if that makes sense?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants