Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

✨ Remove docs to download kantra from container image #257

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

dymurray
Copy link
Contributor

@dymurray dymurray commented Jun 10, 2024

Now that we publish binaries no need to have these docs. It's confusing and doesn't specify the multi-arch bits.

Signed-off-by: Dylan Murray <dymurray@redhat.com>
README.md Outdated

## Setup (For Mac and Windows Only)

On Mac and Windows, a podman machine needs to be started prior to running any commands, unless you are using Docker (for Desktop):
On Mac and Windows, a podman machine needs to be started prior to running any commands:
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

update to container tool has to be running?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Updated, I didn't really feel a need to call out Docker by name considering that we only have documented configuration instructions for podman, but let me know if you disagree

Signed-off-by: Dylan Murray <dymurray@redhat.com>
Copy link
Contributor

@pranavgaikwad pranavgaikwad left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

wondering if we want to move latest instructions to docs/developer.md instead of removing them

@eemcmullan
Copy link
Collaborator

+1 on moving instructions to developer docs

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants