fix: better error message when the max upload size is exceeded #158
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Harikrishnan Balagopal <harikrishmenon@gmail.com>
|
Thanks for making a pull request! 😃 |
Signed-off-by: Harikrishnan Balagopal <harikrishmenon@gmail.com>
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #158 +/- ##
=======================================
Coverage 14.48% 14.48%
=======================================
Files 2 2
Lines 214 214
=======================================
Hits 31 31
Misses 179 179
Partials 4 4 ☔ View full report in Codecov by Sentry. |
ashokponkumar
requested changes
Feb 23, 2024
| @@ -53,6 +53,15 @@ func HandleCreateProjectInput(w http.ResponseWriter, r *http.Request, isCommon b | |||
| } | |||
| r.Body = http.MaxBytesReader(w, r.Body, common.Config.MaxUploadSize) | |||
| if err := r.ParseMultipartForm(common.Config.MaxUploadSize); err != nil { | |||
| if _, ok := err.(*http.MaxBytesError); ok { | |||
| logrus.Errorf("request body exceeded max upload size of '%d' bytes. Error: %q", common.Config.MaxUploadSize, err) | |||
There was a problem hiding this comment.
Would it be good to mention which config to change?
seshapad
previously approved these changes
Feb 23, 2024
…xceeded Signed-off-by: Harikrishnan Balagopal <harikrishmenon@gmail.com>
…ze is exceeded Signed-off-by: Harikrishnan Balagopal <harikrishmenon@gmail.com>
ashokponkumar
approved these changes
Feb 23, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.