Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: Update Golang version in Makefile to prevent cbuild failure #161

Merged
merged 2 commits into from
Mar 20, 2024
Merged

fix: Update Golang version in Makefile to prevent cbuild failure #161

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
594b44e
fix: Update Golang version in Makefile to prevent cbuild failure
Akash-Nayak Mar 14, 2024
dde38e5
fix: Update the supported Golang version in the Readme file
Akash-Nayak Mar 14, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion Makefile
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -19,7 +19,7 @@ TARGETS := darwin/amd64 darwin/arm64 linux/amd64 linux/arm64 windows/amd64
REGISTRYNS := quay.io/konveyor
SWAGGER_UI_VERSION := 3.52.3

GO_VERSION ?= $(shell go run ./scripts/detectgoversion/detect.go 2>/dev/null || printf '1.18')
GO_VERSION ?= $(shell go run ./scripts/detectgoversion/detect.go 2>/dev/null || printf '1.19')
GOPATH = $(shell go env GOPATH)
GOX = $(GOPATH)/bin/gox
GOTEST = ${GOPATH}/bin/gotest
Expand Down
2 changes: 1 addition & 1 deletion README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -21,7 +21,7 @@ Run using container from registry using `make crun`

## Setup

1. Obtain a recent version of `golang`. Known to work with `1.18`.
1. Obtain a recent version of `golang`. Known to work with `1.19`.
1. Ensure `$GOPATH` is set. If it's not set:
1. `mkdir ~/go`
1. `export GOPATH=~/go`
Expand Down
Loading