Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

update to avoid hard coding of the artifactType #30

Merged
merged 4 commits into from
Oct 19, 2020
Merged

update to avoid hard coding of the artifactType #30

merged 4 commits into from
Oct 19, 2020

Commits on Oct 17, 2020

  1. update to avoid hard coding of the artifactType 

    Signed-off-by: Isabella Liu <isabellaliu77@gmail.com>
    @IsabellaDev
    IsabellaDev committed Oct 17, 2020
    Configuration menu
    Copy the full SHA
    d3d5d74 View commit details
    Browse the repository at this point in the history

Commits on Oct 18, 2020

  1. update to remove any hardcoding, and remove possible whitespaces 

    Signed-off-by: Isabella Liu <isabellaliu77@gmail.com>
    @IsabellaDev
    IsabellaDev committed Oct 18, 2020
    Configuration menu
    Copy the full SHA
    5c42e08 View commit details
    Browse the repository at this point in the history

Commits on Oct 19, 2020

  1. updated regexp groups to fetch artifactType 

    Signed-off-by: Isabella Liu <isabellaliu77@gmail.com>
    @IsabellaDev
    IsabellaDev committed Oct 19, 2020
    Configuration menu
    Copy the full SHA
    cd2e1d4 View commit details
    Browse the repository at this point in the history

  2. simplified the logic of setting the value for artifactType 

    Signed-off-by: Isabella Liu <isabellaliu77@gmail.com>
    @IsabellaDev
    IsabellaDev committed Oct 19, 2020
    Configuration menu
    Copy the full SHA
    bfd0eb4 View commit details
    Browse the repository at this point in the history