Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Do not use the default values in the Kubernetes yamls #940

Closed
Akash-Nayak opened this issue Dec 15, 2022 · 1 comment
Closed

Do not use the default values in the Kubernetes yamls #940

Akash-Nayak opened this issue Dec 15, 2022 · 1 comment
Assignees

Comments

@Akash-Nayak
Copy link
Contributor

Is your feature request related to a problem? Please describe.
Do not use the default values in the Kubernetes yamls, helm charts, etc.

Describe the solution you'd like
The yamls should not contain the default values. If someone wants the yamls to contain the default values, that change can be done through config file.

Below is a Deployment yaml generated by Move2Kube. It contains default values in the fields like schedulerName, rollingUpdate, terminationMessagePath, etc.

apiVersion: apps/v1
kind: Deployment
metadata:
  creationTimestamp: null
  labels:
    move2kube.konveyor.io/service: nodejs
  name: nodejs
spec:
  progressDeadlineSeconds: 600
  replicas: 2
  revisionHistoryLimit: 10
  selector:
    matchLabels:
      move2kube.konveyor.io/service: nodejs
  strategy:
    rollingUpdate:
      maxSurge: 25%
      maxUnavailable: 25%
    type: RollingUpdate
  template:
    metadata:
      creationTimestamp: null
      labels:
        move2kube.konveyor.io/service: nodejs
      name: nodejs
    spec:
      containers:
        - image: quay.io/default-myproject/nodejs:latest
          imagePullPolicy: Always
          name: nodejs
          ports:
            - containerPort: 8080
              protocol: TCP
          resources: {}
          terminationMessagePath: /dev/termination-log
          terminationMessagePolicy: File
      dnsPolicy: ClusterFirst
      imagePullSecrets:
        - name: quay-io-imagepullsecret
      restartPolicy: Always
      schedulerName: default-scheduler
      securityContext: {}
      terminationGracePeriodSeconds: 30
status: {}
@Akash-Nayak
Copy link
Contributor Author

Added the feature in the PR #941.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant