feat: Do not use default values in the Kubernetes yamls

[Akash-Nayak]

Addresses #940

Old deployment yaml

apiVersion: apps/v1
kind: Deployment
metadata:
  creationTimestamp: null
  labels:
    move2kube.konveyor.io/service: nodejs
  name: nodejs
spec:
  progressDeadlineSeconds: 600
  replicas: 2
  revisionHistoryLimit: 10
  selector:
    matchLabels:
      move2kube.konveyor.io/service: nodejs
  strategy:
    rollingUpdate:
      maxSurge: 25%
      maxUnavailable: 25%
    type: RollingUpdate
  template:
    metadata:
      creationTimestamp: null
      labels:
        move2kube.konveyor.io/service: nodejs
      name: nodejs
    spec:
      containers:
        - image: quay.io/default-myproject/nodejs:latest
          imagePullPolicy: Always
          name: nodejs
          ports:
            - containerPort: 8080
              protocol: TCP
          resources: {}
          terminationMessagePath: /dev/termination-log
          terminationMessagePolicy: File
      dnsPolicy: ClusterFirst
      imagePullSecrets:
        - name: quay-io-imagepullsecret
      restartPolicy: Always
      schedulerName: default-scheduler
      securityContext: {}
      terminationGracePeriodSeconds: 30
status: {}

New deployment yaml

apiVersion: apps/v1
kind: Deployment
metadata:
  creationTimestamp: null
  labels:
    move2kube.konveyor.io/service: nodejs
  name: nodejs
spec:
  replicas: 2
  selector:
    matchLabels:
      move2kube.konveyor.io/service: nodejs
  strategy: {}
  template:
    metadata:
      creationTimestamp: null
      labels:
        move2kube.konveyor.io/service: nodejs
      name: nodejs
    spec:
      containers:
        - image: quay.io/no-def-new/nodejs:latest
          imagePullPolicy: Always
          name: nodejs
          ports:
            - containerPort: 8080
          resources: {}
      imagePullSecrets:
        - name: quay-io-imagepullsecret
      restartPolicy: Always
      securityContext: {}
status: {}

I have tested enterprise-app deployment on the OCP cluster with the new deploy/yamls files and it's working fine.

Signed-off-by: Akash Nayak akash19nayak@gmail.com

[github-actions]

Thanks for making a pull request! 😃
One of the maintainers will review and advise on the next steps.

[ashokponkumar]

Really nice work Akash! I like it! A few suggestions..

[ashokponkumar]

would setDefaultValuesInYamls be a better name?

[Akash-Nayak]

Yes sure

[Akash-Nayak]

Done.

[ashokponkumar]

Would it be better to use the same name in all configs? like say setDefaultValuesInYamls?

[Akash-Nayak]

Yes sure

[Akash-Nayak]

Done.

[codecov]

Codecov Report

Base: 15.28% // Head: 15.28% // No change to project coverage 👍

Coverage data is based on head (cb60c01) compared to base (5c02947).
Patch coverage: 0.00% of modified lines in pull request are covered.

❗ Current head cb60c01 differs from pull request most recent head 238daa7. Consider uploading reports for the commit 238daa7 to get more accurate results

Additional details and impacted files

@@           Coverage Diff           @@
##             main     #941   +/-   ##
=======================================
  Coverage   15.28%   15.28%           
=======================================
  Files          50       50           
  Lines        4600     4600           
=======================================
  Hits          703      703           
  Misses       3721     3721           
  Partials      176      176           

Impacted Files	Coverage Δ
transformer/kubernetes/apiresource/utils.go	0.00% <0.00%> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

[Akash-Nayak]

Really nice work Akash! I like it! A few suggestions..

Thank you very much, Ashok ji! :-)

[ashokponkumar]

Might be good to rename the internal variables to be set too.

[Akash-Nayak]

Might be good to rename the internal variables to be set too.

Yes sure, done. I missed renaming the internal variables while I was doing case-sensitive find and replace.