Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: panic when placing dynamic params in IR because the "artifact.configs" is nil at some points #1006

Merged

Conversation

HarikrishnanBalagopal
Copy link
Contributor

No description provided.

…nfigs" is nil at some points

Signed-off-by: Harikrishnan Balagopal <harikrishmenon@gmail.com>
@github-actions
Copy link

github-actions bot commented Apr 4, 2023

Thanks for making a pull request! 😃
One of the maintainers will review and advise on the next steps.

@github-actions github-actions bot added the fix label Apr 4, 2023
@codecov
Copy link

codecov bot commented Apr 4, 2023

Codecov Report

Patch and project coverage have no change.

Comparison is base (7fabe36) 18.14% compared to head (acadc9a) 18.14%.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #1006   +/-   ##
=======================================
  Coverage   18.14%   18.14%           
=======================================
  Files          52       52           
  Lines        4823     4823           
=======================================
  Hits          875      875           
  Misses       3729     3729           
  Partials      219      219           

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@ashokponkumar ashokponkumar merged commit c1af24d into konveyor:main Apr 4, 2023
@HarikrishnanBalagopal HarikrishnanBalagopal deleted the fix/panicconfigs branch April 4, 2023 07:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants