feat: Use latest version of go-cfclient v2 for move2kube collect #1015
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Akash Nayak <akash19nayak@gmail.com>
|
Thanks for making a pull request! 😃 |
ashokponkumar
approved these changes
Apr 5, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Using the latest go-cfclient v2 - https://github.com/cloudfoundry-community/go-cfclient/releases/tag/v2.0.0, I have tested
move2kube collectwith CF CLI and IBM Cloud CF CLI, it's working fine and I didn't notice any breaking changes. Then I also ranmove2kube transformon enterprise-app src with the m2k_collect output. I was able to successfully deploy the apps on OpenShift cluster. I had changed the number of instances ofGatewayapp to 3 on IBM Cloud CF. In the gateway-deployment.yaml file, the number ofreplicaswas also set to 3 by Move2Kube.