Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: fail when the paths sent are parent to another #1023

Merged
merged 2 commits into from
Apr 11, 2023

Conversation

kmehant
Copy link
Member

@kmehant kmehant commented Apr 10, 2023

Signed-off-by: Mehant Kammakomati mehant.kammakomati2@ibm.com

Signed-off-by: Mehant Kammakomati <mehant.kammakomati2@ibm.com>
@github-actions
Copy link

Thanks for making a pull request! 😃
One of the maintainers will review and advise on the next steps.

@github-actions github-actions bot added the fix label Apr 10, 2023
@codecov
Copy link

codecov bot commented Apr 10, 2023

Codecov Report

Patch coverage has no change and project coverage change: -0.21 ⚠️

Comparison is base (bf29542) 15.34% compared to head (60cd156) 15.13%.

❗ Current head 60cd156 differs from pull request most recent head 97ee07f. Consider uploading reports for the commit 97ee07f to get more accurate results

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1023      +/-   ##
==========================================
- Coverage   15.34%   15.13%   -0.21%     
==========================================
  Files          74       73       -1     
  Lines        6581     6566      -15     
==========================================
- Hits         1010      994      -16     
- Misses       5318     5320       +2     
+ Partials      253      252       -1     

see 2 files with indirect coverage changes

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@kmehant kmehant requested a review from ashokponkumar April 10, 2023 19:02
@ashokponkumar ashokponkumar enabled auto-merge (squash) April 11, 2023 14:48
@ashokponkumar ashokponkumar merged commit dea5d6e into konveyor:main Apr 11, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants