Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Resolve move2kube images collect error #1053

Merged
merged 1 commit into from
Jun 27, 2023

Conversation

Akash-Nayak
Copy link
Contributor

Resolves #1052

There was no if condition to check whether the err is nil or not. So, move2kube collect -a dockercompose would always return the error message even if the err is nil.

Signed-off-by: Akash Nayak akash19nayak@gmail.com

Signed-off-by: Akash Nayak <akash19nayak@gmail.com>
@github-actions
Copy link

Thanks for making a pull request! 😃
One of the maintainers will review and advise on the next steps.

@github-actions github-actions bot added the fix label Jun 27, 2023
@Akash-Nayak Akash-Nayak requested a review from seshapad June 27, 2023 20:38
@ashokponkumar ashokponkumar enabled auto-merge (squash) June 27, 2023 20:39
@ashokponkumar ashokponkumar merged commit 0576a30 into konveyor:main Jun 27, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

move2kube collect for images returns an error message
2 participants