Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Update Documentation badge link #1068

Merged
merged 3 commits into from
Aug 1, 2023

Conversation

Sumitmaithani
Copy link
Contributor

fixed #1067

fixed konveyor#1067 

Signed-off-by: Sumit Maithani <86047367+Sumitmaithani@users.noreply.github.com>
@github-actions
Copy link

github-actions bot commented Aug 1, 2023

Thanks for making a pull request! 😃
One of the maintainers will review and advise on the next steps.

@seshapad
Copy link
Member

seshapad commented Aug 1, 2023

@Sumitmaithani Please change the PR title to include one of these ['feat', 'fix', 'docs', 'style', 'refactor', 'perf', 'test', 'build', 'ci', 'chore', 'revert']. The automated build check for the PR will validate it and issue error if not specified.

@Sumitmaithani Sumitmaithani changed the title Update Documentation badge link fix : Update Documentation badge link Aug 1, 2023
@Sumitmaithani
Copy link
Contributor Author

Thanks @seshapad for informing.

@seshapad
Copy link
Member

seshapad commented Aug 1, 2023

@Sumitmaithani Please change the PR title to include one of these ['feat', 'fix', 'docs', 'style', 'refactor', 'perf', 'test', 'build', 'ci', 'chore', 'revert']. The automated build check for the PR will validate it and issue error if not specified.

there is space after "fix" and before ":". please remove that.

@codecov
Copy link

codecov bot commented Aug 1, 2023

Codecov Report

Patch and project coverage have no change.

Comparison is base (a49a808) 14.42% compared to head (7ec95df) 14.42%.
Report is 2 commits behind head on main.

❗ Current head 7ec95df differs from pull request most recent head 8172c2a. Consider uploading reports for the commit 8172c2a to get more accurate results

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #1068   +/-   ##
=======================================
  Coverage   14.42%   14.42%           
=======================================
  Files          86       86           
  Lines        8181     8181           
=======================================
  Hits         1180     1180           
  Misses       6695     6695           
  Partials      306      306           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@Sumitmaithani Sumitmaithani changed the title fix : Update Documentation badge link fix: Update Documentation badge link Aug 1, 2023
@github-actions github-actions bot added the fix label Aug 1, 2023
@Sumitmaithani
Copy link
Contributor Author

@Sumitmaithani Please change the PR title to include one of these ['feat', 'fix', 'docs', 'style', 'refactor', 'perf', 'test', 'build', 'ci', 'chore', 'revert']. The automated build check for the PR will validate it and issue error if not specified.

there is space after "fix" and before ":". please remove that.

Oh ! my mistake, thanks

@seshapad
Copy link
Member

seshapad commented Aug 1, 2023

@Sumitmaithani Please change the PR title to include one of these ['feat', 'fix', 'docs', 'style', 'refactor', 'perf', 'test', 'build', 'ci', 'chore', 'revert']. The automated build check for the PR will validate it and issue error if not specified.

there is space after "fix" and before ":". please remove that.

Oh ! my mistake, thanks

no worries. thank you.

README.md Outdated Show resolved Hide resolved
Signed-off-by: Sumit Maithani <86047367+Sumitmaithani@users.noreply.github.com>
Copy link
Contributor

@Akash-Nayak Akash-Nayak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Contributor

@HarikrishnanBalagopal HarikrishnanBalagopal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@HarikrishnanBalagopal HarikrishnanBalagopal enabled auto-merge (squash) August 1, 2023 10:11
@HarikrishnanBalagopal HarikrishnanBalagopal merged commit 817b8c9 into konveyor:main Aug 1, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Documentation badges link broken
4 participants