-
Notifications
You must be signed in to change notification settings - Fork 118
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add support for StatefulSets #1088
feat: add support for StatefulSets #1088
Conversation
Signed-off-by: Soumil Paranjpay <soumil.paranjpay@gmail.com>
Thanks for making a pull request! 😃 |
Signed-off-by: Soumil Paranjpay <soumil.paranjpay@gmail.com>
Signed-off-by: Soumil Paranjpay <soumil.paranjpay@gmail.com>
Codecov ReportPatch coverage has no change and project coverage change:
Additional details and impacted files@@ Coverage Diff @@
## main #1088 +/- ##
==========================================
- Coverage 14.87% 14.68% -0.20%
==========================================
Files 86 86
Lines 8206 8013 -193
==========================================
- Hits 1221 1177 -44
+ Misses 6666 6526 -140
+ Partials 319 310 -9
☔ View full report in Codecov by Sentry. |
Signed-off-by: Soumil Paranjpay <soumil.paranjpay@gmail.com>
Signed-off-by: Soumil Paranjpay <soumil.paranjpay@gmail.com>
Signed-off-by: Soumil-07 <82497827+Soumil-07@users.noreply.github.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Few suggestions..
Signed-off-by: Soumil Paranjpay <soumil.paranjpay@gmail.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I was doing some testing and noticed that in the generated target artifacts, Move2Kube also created Route/Ingress yaml for the services for which I selected yes for StatefuSet and ClusterIP as the service type. I think Ingress/Route should only be created for the service if the user selects Ingress as the service type during the QA.
Can you please also check that and look into this issue @Soumil-07.
cc: @HarikrishnanBalagopal
Signed-off-by: Soumil Paranjpay <soumil.paranjpay@gmail.com>
It should be resolved by 50c367b. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. Thanks @Soumil-07!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
No description provided.