Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add support for StatefulSets #1088

Merged
merged 9 commits into from
Sep 21, 2023

Conversation

Soumil-07
Copy link
Contributor

No description provided.

Signed-off-by: Soumil Paranjpay <soumil.paranjpay@gmail.com>
@github-actions
Copy link

Thanks for making a pull request! 😃
One of the maintainers will review and advise on the next steps.

@github-actions github-actions bot added the feat label Sep 10, 2023
Signed-off-by: Soumil Paranjpay <soumil.paranjpay@gmail.com>
Signed-off-by: Soumil Paranjpay <soumil.paranjpay@gmail.com>
@codecov
Copy link

codecov bot commented Sep 10, 2023

Codecov Report

Patch coverage has no change and project coverage change: -0.20% ⚠️

Comparison is base (1c32feb) 14.87% compared to head (50c367b) 14.68%.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1088      +/-   ##
==========================================
- Coverage   14.87%   14.68%   -0.20%     
==========================================
  Files          86       86              
  Lines        8206     8013     -193     
==========================================
- Hits         1221     1177      -44     
+ Misses       6666     6526     -140     
+ Partials      319      310       -9     
Files Changed Coverage Δ
transformer/kubernetes/apiresource/deployment.go 0.00% <0.00%> (ø)
transformer/kubernetes/apiresource/service.go 0.00% <0.00%> (ø)
...r/kubernetes/irpreprocessor/ingresspreprocessor.go 0.00% <0.00%> (ø)
...former/kubernetes/irpreprocessor/irpreprocessor.go 0.00% <0.00%> (ø)
...mer/kubernetes/irpreprocessor/mergepreprocessor.go 0.00% <ø> (ø)
.../irpreprocessor/normalizecharacterspreprocessor.go 100.00% <ø> (ø)
.../kubernetes/irpreprocessor/registrypreprocessor.go 0.00% <ø> (ø)
...r/kubernetes/irpreprocessor/replicapreprocessor.go 0.00% <ø> (ø)
...bernetes/irpreprocessor/statefulsetpreprocessor.go 0.00% <0.00%> (ø)
types/ir/ir.go 56.79% <ø> (+0.14%) ⬆️

... and 1 file with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Soumil-07 and others added 4 commits September 11, 2023 18:03
Signed-off-by: Soumil Paranjpay <soumil.paranjpay@gmail.com>
Signed-off-by: Soumil Paranjpay <soumil.paranjpay@gmail.com>
Signed-off-by: Soumil-07 <82497827+Soumil-07@users.noreply.github.com>
Copy link
Contributor

@Akash-Nayak Akash-Nayak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Few suggestions..

common/constants.go Outdated Show resolved Hide resolved
types/qaengine/commonqa/commonqa.go Outdated Show resolved Hide resolved
types/qaengine/commonqa/commonqa.go Outdated Show resolved Hide resolved
Signed-off-by: Soumil Paranjpay <soumil.paranjpay@gmail.com>
Copy link
Contributor

@Akash-Nayak Akash-Nayak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I was doing some testing and noticed that in the generated target artifacts, Move2Kube also created Route/Ingress yaml for the services for which I selected yes for StatefuSet and ClusterIP as the service type. I think Ingress/Route should only be created for the service if the user selects Ingress as the service type during the QA.
Can you please also check that and look into this issue @Soumil-07.
cc: @HarikrishnanBalagopal

Signed-off-by: Soumil Paranjpay <soumil.paranjpay@gmail.com>
@Soumil-07
Copy link
Contributor Author

I was doing some testing and noticed that in the generated target artifacts, Move2Kube also created Route/Ingress yaml for the services for which I selected yes for StatefuSet and ClusterIP as the service type. I think Ingress/Route should only be created for the service if the user selects Ingress as the service type during the QA.
Can you please also check that and look into this issue @Soumil-07.
cc: @HarikrishnanBalagopal

It should be resolved by 50c367b.

Copy link
Contributor

@Akash-Nayak Akash-Nayak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks @Soumil-07!

Copy link
Contributor

@HarikrishnanBalagopal HarikrishnanBalagopal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@HarikrishnanBalagopal HarikrishnanBalagopal merged commit 1862c9c into konveyor:main Sep 21, 2023
@Soumil-07 Soumil-07 deleted the feat/statefulset branch September 25, 2023 12:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants