fix: add condition for version_metadata in Makefile #1128
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for making a pull request! 😃 |
akagami-harsh
changed the title
|
@akagami-harsh thanks for the contribution, can you rebase this branch fetching the updates? |
akagami-harsh
force-pushed
the
version-metadata-bugfix
branch
from
f107e6a to
a22e035
Compare
|
done! |
Signed-off-by: Harshvir Potpose <hpotpose62@gmail.com>
HarikrishnanBalagopal
force-pushed
the
version-metadata-bugfix
branch
from
a22e035 to
2144ddb
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1128 +/- ##
=======================================
Coverage 14.89% 14.89%
=======================================
Files 90 90
Lines 8380 8380
=======================================
Hits 1248 1248
Misses 6809 6809
Partials 323 323 ☔ View full report in Codecov by Sentry. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
VERSION_METADATA