-
Notifications
You must be signed in to change notification settings - Fork 118
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
docs: add instructions for setting an alias for the move2kube
command in the shell
#1139
Conversation
Thanks for making a pull request! 😃 |
@Sanket-0510 I think you forgot to sign your commit. To fix this please read this Also please read the contribution.md |
d7bc9ef
to
79029a2
Compare
Hey @KrishAryan you can review this. |
@Sanket-0510 I think it would look better if you write 'To keep aliases between sessions, you can save them in your user’s shell configuration profile file' and give the example of only bash script otherwise the readme will look unnecessarily long. I am not a maintainer so I cannot approve this for you but wanted to help save their time. |
will you please highlight in the code, the exact place |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
between line 127 and line 129 you can add the comment and remove zsh and fish section.Also use three hashags in line 127 instead of two so that it can look better.
Also in your second commit which is in go.mod file, why did you do the changes in line 22 and removed line 119
Hey, actually, it's the Go package manager, I guess, which made the changes. I didn't explicitly change it, and the build is successful on my side, I ran these commands, |
@kmehant can you please review and approve it? |
Signed-off-by: sanket <telisanket2002@gmail.com>
Signed-off-by: sanket <telisanket2002@gmail.com>
7d2a2d7
to
d5a16c4
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
move2kube
command in the shell
move2kube
command in the shellmove2kube
command in the shell
as discussed here #1135 I feel there is a strong need to address, its all okay if we can't change it during installation but shall surely have section to address the same. Because writing 'move2kube' becomes a tedious task for sure.