feat: add support for file path #1141
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for making a pull request! 😃 |
mohit-marathe
force-pushed
the
copy-file
branch
from
13f28f8 to
06ac7b6
Compare
Signed-off-by: Mohit Marathe <mohitmarathe@proton.me>
mohit-marathe
force-pushed
the
copy-file
branch
from
06ac7b6 to
2d93413
Compare
|
@kmehant @HarikrishnanBalagopal Please review this PR! |
HarikrishnanBalagopal
requested changes
Mar 21, 2024
| for sp, dp := range paths { | ||
| err = copyDirToContainer(e.ctx, e.cli, containerID, sp, dp) | ||
| fi, err := os.Stat(sp) |
There was a problem hiding this comment.
Fix indentation. Use go fmt.
If you are using a text editor like VSCode, VIM, Sublime, etc. installing the Golang extension automatically runs the go formatter when you save the file.
| } | ||
| } else { | ||
| newDestPath := filepath.Join(dp, fi.Name()) | ||
| err = copyDirToContainer(e.ctx, e.cli, containerID, sp, newDestPath) |
There was a problem hiding this comment.
If copyDirToContainer is being used to copy files then we should rename it as well.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes: #1039