Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: match the golang version in go.mod #493

Merged
merged 1 commit into from
May 10, 2021
Merged

fix: match the golang version in go.mod #493

merged 1 commit into from
May 10, 2021

Conversation

HarikrishnanBalagopal
Copy link
Contributor

Signed-off-by: Harikrishnan Balagopal harikrishmenon@gmail.com

@github-actions
Copy link

github-actions bot commented May 7, 2021

Thanks for making a pull request! 😃
One of the maintainers will review and advise on the next steps.

@github-actions github-actions bot added the fix label May 7, 2021
@codecov
Copy link

codecov bot commented May 7, 2021 •
edited
Loading

Codecov Report

Merging #493 (637c6ce) into main (266c00b) will not change coverage.
The diff coverage is n/a.

❗ Current head 637c6ce differs from pull request most recent head 23b24a1. Consider uploading reports for the commit 23b24a1 to get more accurate results
Impacted file tree graph

@@           Coverage Diff           @@
##             main     #493   +/-   ##
=======================================
  Coverage   23.99%   23.99%           
=======================================
  Files          69       69           
  Lines        4697     4697           
=======================================
  Hits         1127     1127           
  Misses       3443     3443           
  Partials      127      127

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 266c00b...23b24a1. Read the comment docs.

@ashokponkumar
Copy link
Member

ashokponkumar commented May 7, 2021 •
edited
Loading

We should rather try to change the Makefile to detect from go.mod, so that even if we forgot to change this value next time, it will autoadopt.

@HarikrishnanBalagopal HarikrishnanBalagopal force-pushed the fix/makecbuild branch 2 times, most recently from 166a09c to 637c6ce Compare May 7, 2021 10:10
ashokponkumar
ashokponkumar reviewed May 8, 2021
View reviewed changes
go.mod Outdated
@@ -37,6 +37,7 @@ require (
github.com/xrash/smetrics v0.0.0-20200730060457-89a2a8a1fb0b
go.starlark.net v0.0.0-20210223155950-e043a3d3c984
golang.org/x/crypto v0.0.0-20210322153248-0c34fe9e7dc2
golang.org/x/mod v0.3.0
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is this change required for usage as script? Is there no way to avoid build/dev dependencies from prod dependencies?

Copy link
Contributor Author

@HarikrishnanBalagopal HarikrishnanBalagopal May 10, 2021 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The golang extension package mod is used to parse the go.mod file and get the configured Go version.
Golang doesn't have dev and prod dependencies, see:
golang/go#27653
golang/go#25922

@HarikrishnanBalagopal
fix: match the golang version in go.mod
23b24a1 
Signed-off-by: Harikrishnan Balagopal <harikrishmenon@gmail.com>
@ashokponkumar ashokponkumar enabled auto-merge (squash) May 10, 2021 11:34
@ashokponkumar ashokponkumar merged commit b626652 into konveyor:main May 10, 2021
@HarikrishnanBalagopal HarikrishnanBalagopal deleted the fix/makecbuild branch May 10, 2021 11:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ashokponkumar ashokponkumar ashokponkumar approved these changes

Assignees
No one assigned
Labels
fix
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@HarikrishnanBalagopal @ashokponkumar