Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: add crypto utils, template functions and ibm vpc certificate #865

Merged
merged 2 commits into from
Sep 16, 2022
Merged

feat: add crypto utils, template functions and ibm vpc certificate #865

merged 2 commits into from
Sep 16, 2022

Conversation

kmehant
Copy link
Member

@kmehant kmehant commented Sep 16, 2022

Signed-off-by: Mehant Kammakomati kmehant@gmail.com

@github-actions
Copy link

Thanks for making a pull request! 😃
One of the maintainers will review and advise on the next steps.

@github-actions github-actions bot added the feat label Sep 16, 2022
@kmehant kmehant added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Sep 16, 2022
@codecov
Copy link

codecov bot commented Sep 16, 2022 •
edited
Loading

Codecov Report

Base: 18.11% // Head: 18.11% // No change to project coverage 👍

Coverage data is based on head (5480b23) compared to base (5064d5f).
Patch has no changes to coverable lines.

❗ Current head 5480b23 differs from pull request most recent head 2b141ba. Consider uploading reports for the commit 2b141ba to get more accurate results

Additional details and impacted files 
@@           Coverage Diff           @@
##             main     #865   +/-   ##
=======================================
  Coverage   18.11%   18.11%           
=======================================
  Files          46       46           
  Lines        3731     3731           
=======================================
  Hits          676      676           
  Misses       2890     2890           
  Partials      165      165

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

ashokponkumar
ashokponkumar requested changes Sep 16, 2022
View reviewed changes
Copy link
Member

@ashokponkumar ashokponkumar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good start. Few initial comments

assets/assets.go Outdated Show resolved Hide resolved
common/cryptoutils.go Outdated Show resolved Hide resolved
@kmehant
feat: add crypto utils, template functions and ibm vpc certificate
7a58987 
Signed-off-by: Mehant Kammakomati <kmehant@gmail.com>
@kmehant
Copy link
Member Author

kmehant commented Sep 16, 2022

@ashokponkumar I have shifted it to https://github.com/konveyor/move2kube-transformers/pull/35/files#diff-f555fc879e485800f83a901bdaab484b50bde2f35425c8b8377ba880354400afR16-R17 and tested it!

ashokponkumar
ashokponkumar requested changes Sep 16, 2022
View reviewed changes
Copy link
Member

@ashokponkumar ashokponkumar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Also make them available to starlark as custom functions

filesystem/templatecopy.go Outdated Show resolved Hide resolved
ashokponkumar
ashokponkumar requested changes Sep 16, 2022
View reviewed changes
filesystem/templatecopy.go Outdated
var err error
methodMap := template.FuncMap{
"execTpl": execTpl(packageTemplate),
"aesCbcPbkdfEnc": common.AesCbcEncryptWithPbkdfWrapper,
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Probably will help to have a prefix like say encryptAesCbcPbkdf and encrypt_ RsaCert, so that it is easier to decipher the various functions.

@kmehant kmehant force-pushed the feat-crypto-utils branch 2 times, most recently from 91ecaa7 to 5480b23 Compare September 16, 2022 15:55
@kmehant
fix: remove transformer specific files and code from m2k core
2b141ba 
Signed-off-by: Mehant Kammakomati <kmehant@gmail.com>
ashokponkumar
ashokponkumar approved these changes Sep 16, 2022
View reviewed changes
Copy link
Member

@ashokponkumar ashokponkumar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice work!

@ashokponkumar ashokponkumar enabled auto-merge (squash) September 16, 2022 16:15
@ashokponkumar ashokponkumar merged commit c21c835 into konveyor:main Sep 16, 2022
@ashokponkumar ashokponkumar removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Sep 16, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ashokponkumar ashokponkumar ashokponkumar approved these changes

@HarikrishnanBalagopal HarikrishnanBalagopal Awaiting requested review from HarikrishnanBalagopal

Assignees
No one assigned
Labels
feat
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@kmehant @ashokponkumar