Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add resources dir starlark custom variable #867

Merged
merged 2 commits into from
Sep 19, 2022

Conversation

kmehant
Copy link
Member

@kmehant kmehant commented Sep 19, 2022

Signed-off-by: Mehant Kammakomati kmehant@gmail.com

Signed-off-by: Mehant Kammakomati <kmehant@gmail.com>
@github-actions
Copy link

Thanks for making a pull request! 😃
One of the maintainers will review and advise on the next steps.

@codecov
Copy link

codecov bot commented Sep 19, 2022

Codecov Report

Base: 18.11% // Head: 18.11% // No change to project coverage 👍

Coverage data is based on head (3c6d2b0) compared to base (c21c835).
Patch has no changes to coverable lines.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #867   +/-   ##
=======================================
  Coverage   18.11%   18.11%           
=======================================
  Files          46       46           
  Lines        3731     3731           
=======================================
  Hits          676      676           
  Misses       2890     2890           
  Partials      165      165           

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

Copy link
Member

@ashokponkumar ashokponkumar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We should not be exposing the assets directory. Its internal to move2kube. Rather each transformer can use the context dir. context_dir

Signed-off-by: Mehant Kammakomati <kmehant@gmail.com>
@kmehant kmehant changed the title feat: add assets starlark custom function feat: add resources dir starlark custom function Sep 19, 2022
@kmehant kmehant changed the title feat: add resources dir starlark custom function feat: add resources dir starlark custom variable Sep 19, 2022
@ashokponkumar ashokponkumar merged commit 4caa926 into konveyor:main Sep 19, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants