Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: add starlark custom functions for crypto and archive utils #871

Merged
merged 2 commits into from
Sep 21, 2022
Merged

feat: add starlark custom functions for crypto and archive utils #871

merged 2 commits into from
Sep 21, 2022

Conversation

kmehant
Copy link
Member

@kmehant kmehant commented Sep 21, 2022

Signed-off-by: Mehant Kammakomati kmehant@gmail.com

@github-actions
Copy link

Thanks for making a pull request! 😃
One of the maintainers will review and advise on the next steps.

@github-actions github-actions bot added the fix label Sep 21, 2022
@codecov
Copy link

codecov bot commented Sep 21, 2022 •
edited
Loading

Codecov Report

Base: 18.40% // Head: 18.40% // No change to project coverage 👍

Coverage data is based on head (09b81d9) compared to base (1197835).
Patch has no changes to coverable lines.

Additional details and impacted files 
@@           Coverage Diff           @@
##             main     #871   +/-   ##
=======================================
  Coverage   18.40%   18.40%           
=======================================
  Files          46       46           
  Lines        3672     3672           
=======================================
  Hits          676      676           
  Misses       2831     2831           
  Partials      165      165

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

ashokponkumar
ashokponkumar requested changes Sep 21, 2022
View reviewed changes
transformer/external/starlarktransformer.go Outdated
@@ -68,6 +68,13 @@ const (
fswriteFnName = "write"
fspathBaseFnName = "pathbase"
fspathRelFnName = "pathrel"

// encryption functions
encaescbcpbkdfFnName = "encaescbcpbkdf"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we have to reevaluate starlark function naming conventions. These function names are almost unreadable. Can you please check the conventions and come with with alternatives

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Shall we track this in a separate PR?

@kmehant kmehant changed the title fix: add starlark custom functions for crypto and archive utils feat: add starlark custom functions for crypto and archive utils Sep 21, 2022
@kmehant kmehant added feat and removed fix labels Sep 21, 2022
@kmehant
feat: add starlark custom functions for crypto and archive utils
b651057 
Signed-off-by: Mehant Kammakomati <kmehant@gmail.com>
@kmehant
fix: use snake case for starlark custom functions
09b81d9 
Signed-off-by: Mehant Kammakomati <kmehant@gmail.com>
@ashokponkumar ashokponkumar merged commit 75e97b8 into konveyor:main Sep 21, 2022
@ashokponkumar ashokponkumar mentioned this pull request Sep 22, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ashokponkumar ashokponkumar ashokponkumar approved these changes

Assignees
No one assigned
Labels
feat
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@kmehant @ashokponkumar