feat: let the user decide if they want planning to fail if no services are detected #878
Conversation
…s are detected Signed-off-by: Harikrishnan Balagopal <harikrishmenon@gmail.com>
|
Thanks for making a pull request! 😃 |
Codecov ReportBase: 18.40% // Head: 18.40% // No change to project coverage 👍
Additional details and impacted files@@ Coverage Diff @@
## main #878 +/- ##
=======================================
Coverage 18.40% 18.40%
=======================================
Files 46 46
Lines 3672 3672
=======================================
Hits 676 676
Misses 2831 2831
Partials 165 165 Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
|
If I understand it correctly, |
@anwarchk This particular PR has nothing to do with Cf bound services. But we are currently working on a capability to migrate bound services to either as Operators or services in Cloud catalogs. Here is a discussion on this topic. Please do let us know your usecase, how you are using Move2Kube, and how you would like Move2Kube transform the services, so that we can feed that into feature design for services migration. We can also continue the conversation in slack. |
cmd/plan.go
Outdated
| logrus.Debugf("Plan : %+v", p) | ||
| logrus.Fatalf("failed to find any services or default transformers.") | ||
| if flags.failOnEmptyPlan { | ||
| logrus.Fatalf("Did not detect any services in the directory %s", srcpath) |
There was a problem hiding this comment.
we might also want to mention about default transformers similar to the previous message.
…services are detected Signed-off-by: Harikrishnan Balagopal <harikrishmenon@gmail.com>
| logrus.Fatalf("Did not detect any services in the directory %s . Also we didn't find any default transformers to run.", srcpath) | ||
| } | ||
| logrus.Warnf("Did not detect any services in the directory %s . Also we didn't find any default transformers to run.", srcpath) |
There was a problem hiding this comment.
Should we say InvokedByDefault transformers to stick with a single terminology
Signed-off-by: Harikrishnan Balagopal harikrishmenon@gmail.com