chore: update the go.mod file to fix minor issues #883
Conversation
HarikrishnanBalagopal
changed the title
|
Thanks for making a pull request! 😃 |
Signed-off-by: Harikrishnan Balagopal <harikrishmenon@gmail.com>
|
Thanks for making a pull request! 😃 |
HarikrishnanBalagopal
force-pushed
the
chore/updategomodfile
branch
from
ecd89ff to
6b8512d
Compare
HarikrishnanBalagopal
changed the title
github-actions
bot
added
chore
Codecov ReportBase: 18.40% // Head: 18.40% // No change to project coverage 👍
Additional details and impacted files@@ Coverage Diff @@
## main #883 +/- ##
=======================================
Coverage 18.40% 18.40%
=======================================
Files 46 46
Lines 3672 3672
=======================================
Hits 676 676
Misses 2831 2831
Partials 165 165 Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
| relpath, err := filepath.Rel(inputPath, path) | ||
| if err != nil { | ||
| logrus.Errorf("failed to make the directory %s relative to the input directory %s . Error: %q", path, inputPath, err) | ||
| continue |
There was a problem hiding this comment.
Since it is only for log, we need not continue, but rather print error and proceed to log.
There was a problem hiding this comment.
Even if it is only for log it should not fail. I have made the change.
Signed-off-by: Harikrishnan Balagopal <harikrishmenon@gmail.com>
Signed-off-by: Harikrishnan Balagopal harikrishmenon@gmail.com