fix: deselect the console and silverlight transformer by default to avoid conflicts with dotnet webapp transformer #889
Conversation
|
Thanks for making a pull request! 😃 |
Done |
Codecov ReportBase: 18.40% // Head: 18.40% // No change to project coverage 👍
Additional details and impacted files@@ Coverage Diff @@
## main #889 +/- ##
=======================================
Coverage 18.40% 18.40%
=======================================
Files 46 46
Lines 3672 3672
=======================================
Hits 676 676
Misses 2831 2831
Partials 165 165
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
types/plan/plan.go
Outdated
| TransformerSelector metav1.LabelSelector `yaml:"transformerSelector,omitempty"` | ||
| Transformers map[string]string `yaml:"transformers,omitempty" m2kpath:"normal"` //[name]filepath | ||
| InvokedByDefaultTransformers []string `yaml:"invokedByDefaultTransformers,omitempty"` | ||
| DisabledTransformers []string `yaml:"disabledTransformers,omitempty"` |
There was a problem hiding this comment.
It might be good to have the path here too. Probably as a 2d array to allow for more than one path for a transformer.
transformer/transformer.go
Outdated
| defaultSelectedTransformerNames, | ||
| transformerNames, | ||
| ) | ||
| deselectedTransformerNames := []string{} |
There was a problem hiding this comment.
If we are adding a section for disabled transformers, it might be good to add those disabled because of filters and errors too.
…void conflicts with dotnet webapp transformer Signed-off-by: Harikrishnan Balagopal <harikrishmenon@gmail.com>
HarikrishnanBalagopal
force-pushed
the
fix/deselecttransformers
branch
from
9ef4633 to
4500081
Compare
See #888
Signed-off-by: Harikrishnan Balagopal harikrishmenon@gmail.com