Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add validator and retries to qa engine #898

Merged
merged 4 commits into from
Oct 13, 2022

Conversation

kmehant
Copy link
Member

@kmehant kmehant commented Oct 13, 2022

Signed-off-by: Mehant Kammakomati kmehant@gmail.com

@github-actions
Copy link

Thanks for making a pull request! 😃
One of the maintainers will review and advise on the next steps.

@github-actions github-actions bot added the feat label Oct 13, 2022
@kmehant
Copy link
Member Author

kmehant commented Oct 13, 2022

This would work irrespective of the engines. This PR does not cover the GRPC usecase for the following reasons.

  1. sending a function is not yet thought thoroughly through GRPC
  2. adding pattern based validation just for the GRPC, would create inconsistency with the validation function that the current PR incorporates

@codecov
Copy link

codecov bot commented Oct 13, 2022

Codecov Report

Base: 18.40% // Head: 18.13% // Decreases project coverage by -0.27% ⚠️

Coverage data is based on head (7440cc5) compared to base (8b4b2ea).
Patch coverage: 6.06% of modified lines in pull request are covered.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #898      +/-   ##
==========================================
- Coverage   18.40%   18.13%   -0.28%     
==========================================
  Files          46       47       +1     
  Lines        3672     3733      +61     
==========================================
+ Hits          676      677       +1     
- Misses       2831     2887      +56     
- Partials      165      169       +4     
Impacted Files Coverage Δ
environment/container/container.go 0.00% <0.00%> (ø)
qaengine/cliengine.go 0.00% <0.00%> (ø)
qaengine/httprestengine.go 0.00% <0.00%> (ø)
transformer/kubernetes/apiresource/service.go 0.00% <0.00%> (ø)
...r/kubernetes/irpreprocessor/ingresspreprocessor.go 0.00% <0.00%> (ø)
.../kubernetes/irpreprocessor/registrypreprocessor.go 0.00% <0.00%> (ø)
types/qaengine/problem.go 0.00% <0.00%> (ø)
types/qaengine/qaengine.go 0.00% <0.00%> (ø)
qaengine/defaultengine.go 36.36% <14.28%> (-43.64%) ⬇️
qaengine/storeengine.go 36.36% <25.00%> (-38.64%) ⬇️
... and 1 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

Signed-off-by: Mehant Kammakomati <kmehant@gmail.com>
Signed-off-by: Mehant Kammakomati <kmehant@gmail.com>
@kmehant
Copy link
Member Author

kmehant commented Oct 13, 2022

@HarikrishnanBalagopal Ready for review!

Signed-off-by: Mehant Kammakomati <kmehant@gmail.com>
Copy link
Contributor

@HarikrishnanBalagopal HarikrishnanBalagopal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Signed-off-by: Mehant Kammakomati <kmehant@gmail.com>
@HarikrishnanBalagopal HarikrishnanBalagopal merged commit 96400a0 into konveyor:main Oct 13, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants