-
Notifications
You must be signed in to change notification settings - Fork 118
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add validator and retries to qa engine #898
Conversation
Thanks for making a pull request! 😃 |
This would work irrespective of the engines. This PR does not cover the GRPC usecase for the following reasons.
|
Codecov ReportBase: 18.40% // Head: 18.13% // Decreases project coverage by
Additional details and impacted files@@ Coverage Diff @@
## main #898 +/- ##
==========================================
- Coverage 18.40% 18.13% -0.28%
==========================================
Files 46 47 +1
Lines 3672 3733 +61
==========================================
+ Hits 676 677 +1
- Misses 2831 2887 +56
- Partials 165 169 +4
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
Signed-off-by: Mehant Kammakomati <kmehant@gmail.com>
Signed-off-by: Mehant Kammakomati <kmehant@gmail.com>
@HarikrishnanBalagopal Ready for review! |
Signed-off-by: Mehant Kammakomati <kmehant@gmail.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Signed-off-by: Mehant Kammakomati <kmehant@gmail.com>
Signed-off-by: Mehant Kammakomati kmehant@gmail.com