Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: Added containerized tranformer input/output configurability #907

Merged
merged 11 commits into from
Nov 29, 2022
Merged

feat: Added containerized tranformer input/output configurability #907

merged 11 commits into from
Nov 29, 2022

Conversation

seshapad
Copy link
Member

@seshapad seshapad commented Nov 3, 2022

Signed-off-by: seshapad seshapad@in.ibm.com

@github-actions
Copy link

github-actions bot commented Nov 3, 2022

Thanks for making a pull request! 😃
One of the maintainers will review and advise on the next steps.

@github-actions github-actions bot added the feat label Nov 3, 2022
@seshapad seshapad added do-not-merge DEPRECATED. Indicates that a PR should not merge. Label can only be manually applied/removed. and removed feat labels Nov 3, 2022
@github-actions github-actions bot added the feat label Nov 3, 2022
@codecov
Copy link

codecov bot commented Nov 3, 2022 •
edited
Loading

Codecov Report

Base: 15.30% // Head: 15.30% // No change to project coverage 👍

Coverage data is based on head (b529fce) compared to base (b915bb4).
Patch has no changes to coverable lines.

❗ Current head b529fce differs from pull request most recent head b0477d1. Consider uploading reports for the commit b0477d1 to get more accurate results

Additional details and impacted files 
@@           Coverage Diff           @@
##             main     #907   +/-   ##
=======================================
  Coverage   15.30%   15.30%           
=======================================
  Files          50       50           
  Lines        4568     4568           
=======================================
  Hits          699      699           
  Misses       3696     3696           
  Partials      173      173

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@seshapad seshapad removed the do-not-merge DEPRECATED. Indicates that a PR should not merge. Label can only be manually applied/removed. label Nov 7, 2022
@seshapad seshapad force-pushed the etmorecfg branch 2 times, most recently from 2aa7c6b to 4df53a0 Compare November 10, 2022 07:02
ashokponkumar
ashokponkumar requested changes Nov 13, 2022
View reviewed changes
Copy link
Member

@ashokponkumar ashokponkumar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks Nabha. Few suggestions.

environment/environment.go Outdated Show resolved Hide resolved
environment/local.go Outdated Show resolved Hide resolved
transformer/external/executabletransformer.go Outdated Show resolved Hide resolved
transformer/external/executabletransformer.go Outdated Show resolved Hide resolved
transformer/external/executabletransformer.go Outdated Show resolved Hide resolved
ashokponkumar
ashokponkumar requested changes Nov 16, 2022
View reviewed changes
Copy link
Member

@ashokponkumar ashokponkumar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks Nabha. Few more comments.

transformer/external/executabletransformer.go Outdated Show resolved Hide resolved
transformer/external/executabletransformer.go Outdated Show resolved Hide resolved
transformer/external/executabletransformer.go Outdated Show resolved Hide resolved
transformer/external/executabletransformer.go Outdated Show resolved Hide resolved
@seshapad seshapad force-pushed the etmorecfg branch 2 times, most recently from 7a346f3 to 8c2e16e Compare November 22, 2022 05:19
ashokponkumar
ashokponkumar requested changes Nov 28, 2022
View reviewed changes
Copy link
Member

@ashokponkumar ashokponkumar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks ji.. one small suggestion

transformer/external/executabletransformer.go Outdated
cmdToRun := cmd
for envKey, value := range kvMap {
for index, token := range cmdToRun {
regexExp := regexp.MustCompile(`\$` + envKey)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
regexExp := regexp.MustCompile(`\$` + envKey)
regexExp := regexp.MustCompile(`\$({\()?` + envKey + "(}\))?")

Should we allow the brackets too?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

done. The above line had a minor syntax error for the quotes. Hence, I have pushed the change to PR.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There seems to a bug in the above regex. Will try to isolate it.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

done.

HarikrishnanBalagopal and others added 10 commits November 29, 2022 11:49
@HarikrishnanBalagopal @seshapad
fix: parameters in parameterizer templates were not being filled in w…
2d3d513 
…ith the correct values

Signed-off-by: Harikrishnan Balagopal <harikrishmenon@gmail.com>
@HarikrishnanBalagopal @seshapad
fixup! fix: parameters in parameterizer templates were not being fill…
367a37e 
…ed in with the correct values

Signed-off-by: Harikrishnan Balagopal <harikrishmenon@gmail.com>
@seshapad
feat: Added containerized tranformer input/output configurability to …
1876eab 
…samples

Signed-off-by: seshapad <seshapad@in.ibm.com>
@seshapad
feat: Added containerized tranformer input/output configurability to …
270484b 
…samples

Signed-off-by: seshapad <seshapad@in.ibm.com>
@seshapad
feat: Added containerized tranformer input/output configurability to …
d6544d9 
…samples

Signed-off-by: seshapad <seshapad@in.ibm.com>
@seshapad
feat: Added containerized tranformer input/output configurability to …
dee3adb 
…samples

Signed-off-by: seshapad <seshapad@in.ibm.com>
@seshapad
feat: Added containerized tranformer input/output configurability to …
35b6ca6 
…samples

Signed-off-by: seshapad <seshapad@in.ibm.com>
@seshapad
feat: Added containerized tranformer input/output configurability to …
816552b 
…samples

Signed-off-by: seshapad <seshapad@in.ibm.com>
@seshapad
feat: Added containerized tranformer input/output configurability to …
fdd3931 
…samples

Signed-off-by: seshapad <seshapad@in.ibm.com>
@seshapad
feat: Added containerized tranformer input/output configurability to …
b529fce 
…samples

Signed-off-by: seshapad <seshapad@in.ibm.com>
@seshapad
feat: Added containerized tranformer input/output configurability
b0477d1 
Signed-off-by: seshapad <seshapad@in.ibm.com>
@ashokponkumar ashokponkumar enabled auto-merge (squash) November 29, 2022 08:58
@ashokponkumar ashokponkumar merged commit 339e5b7 into konveyor:main Nov 29, 2022
deewhyweb pushed a commit to deewhyweb/move2kube that referenced this pull request Nov 30, 2022
@seshapad @deewhyweb
feat: Added containerized tranformer input/output configurability (ko…
54fc65f 
…nveyor#907)

Signed-off-by: seshapad <seshapad@in.ibm.com>
Signed-off-by: Philip Hayes <philip@deewhy.ie>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ashokponkumar ashokponkumar ashokponkumar approved these changes

Assignees
No one assigned
Labels
feat
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@seshapad @ashokponkumar @HarikrishnanBalagopal