fix: when the user specifies a replicas other than 2 it is not properly reflected in the Helm chart values.yaml #918
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Bug
Steps to reproduce
move2kube plan -s src
andmove2kube transform
Expected behaviour
The output yamls and helm chart values.yaml should have the replicas set to
33
Actual behaviour
In the output
deploy/yamls/
all theDeployment
yamls have the replicas set to33
.In the output
deploy/yamls-parameterized/
folder has Helm chart, Kustomize and Openshift Template all of which have replicas set to2
.This is because the
default
value in a parameterizer yaml always replaces the original value at the location.https://github.com/konveyor/move2kube/blob/main/assets/built-in/transformers/kubernetes/parameterizer/parameterizers/replicas.yaml#L9
Fix
Add a new option to allow keeping the original value if present.
Signed-off-by: Harikrishnan Balagopal harikrishmenon@gmail.com