fix: pull secret getting created even when no authentication is selected

[HarikrishnanBalagopal]

Signed-off-by: Harikrishnan Balagopal harikrishmenon@gmail.com

[github-actions]

Thanks for making a pull request! 😃
One of the maintainers will review and advise on the next steps.

[ashokponkumar]

Suggested change

	createPullSecret = true
	createPullSecretFromDockerConfig = true

[HarikrishnanBalagopal]

Partially fixes #902

[HarikrishnanBalagopal]

$ ls myproject/deploy/yamls
golang-deployment.yaml  golang-service.yaml  myproject-ingress.yaml  quay-io-imagepullsecret-secret.yaml

This fixes the pull secret getting created even when we answer

? [quay.io] What type of container registry login do you want to use?
ID: move2kube.target.imageregistry."quay.io".logintype
Hints:
- Docker login from config mode, will use the default config from your local machine.

 no authentication

[HarikrishnanBalagopal]

$ ls myproject/deploy/yamls
all.icr.io-secret.yaml  golang-deployment.yaml  golang-service.yaml  myproject-ingress.yaml

This also fixes the pull secret getting created when we select use an existing pull secret option

? [quay.io] Enter the name of the pull secret : 
ID: move2kube.target.imageregistry."quay.io".pullsecret
Hints:
- The pull secret should exist in the namespace where you will be deploying the application.

 all.icr.io