Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: use the new Tackle Contianer Advisor image from the konveyor repos #938

Merged

Conversation

HarikrishnanBalagopal
Copy link
Contributor

Signed-off-by: Harikrishnan Balagopal harikrishmenon@gmail.com

…epos

Signed-off-by: Harikrishnan Balagopal <harikrishmenon@gmail.com>
@github-actions
Copy link

Thanks for making a pull request! 😃
One of the maintainers will review and advise on the next steps.

@github-actions github-actions bot added the chore Maintenance work to keep everything working correctly. label Dec 13, 2022
@@ -1,4 +1,5 @@
# FROM quay.io/konveyor/tca-service-api
FROM quay.io/mihirc36/tackle-container-advisor
# FROM quay.io/mihirc36/tackle-container-advisor
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We can possibly remove this line completely

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

done

@codecov
Copy link

codecov bot commented Dec 13, 2022

Codecov Report

Base: 15.28% // Head: 15.28% // No change to project coverage 👍

Coverage data is based on head (e68901e) compared to base (49244a8).
Patch has no changes to coverable lines.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #938   +/-   ##
=======================================
  Coverage   15.28%   15.28%           
=======================================
  Files          50       50           
  Lines        4600     4600           
=======================================
  Hits          703      703           
  Misses       3721     3721           
  Partials      176      176           

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

…veyor repos

Signed-off-by: Harikrishnan Balagopal <harikrishmenon@gmail.com>
@ashokponkumar ashokponkumar merged commit 5c02947 into konveyor:main Dec 13, 2022
@HarikrishnanBalagopal HarikrishnanBalagopal deleted the chore/updatetcaimage branch December 22, 2022 06:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
chore Maintenance work to keep everything working correctly.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants