Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: posting a solution to the qa server was blocking till the channel cleared #946

Merged

Conversation

HarikrishnanBalagopal
Copy link
Contributor

Signed-off-by: Harikrishnan Balagopal harikrishmenon@gmail.com

…l cleared

Signed-off-by: Harikrishnan Balagopal <harikrishmenon@gmail.com>
@github-actions
Copy link

Thanks for making a pull request! 😃
One of the maintainers will review and advise on the next steps.

@github-actions github-actions bot added the fix label Jan 14, 2023
@codecov
Copy link

codecov bot commented Jan 14, 2023

Codecov Report

Base: 15.24% // Head: 15.24% // No change to project coverage 👍

Coverage data is based on head (09c0e75) compared to base (b2ca105).
Patch coverage: 0.00% of modified lines in pull request are covered.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #946   +/-   ##
=======================================
  Coverage   15.24%   15.24%           
=======================================
  Files          50       50           
  Lines        4611     4611           
=======================================
  Hits          703      703           
  Misses       3732     3732           
  Partials      176      176           
Impacted Files Coverage Δ
qaengine/httprestengine.go 0.00% <0.00%> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@ashokponkumar ashokponkumar merged commit 1cb2304 into konveyor:main Jan 15, 2023
@HarikrishnanBalagopal HarikrishnanBalagopal deleted the fix/preventblocking branch January 15, 2023 10:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants